Backporting changes to release-v1.2 by eapolinario · Pull Request #1517 · flyteorg/flytekit

eapolinario · 2023-02-22T22:29:31Z

TL;DR

Backport recent changes to the release-v1.2 branch

List of backported changes:

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

…1240) * first commit Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * add tensorflow example tf record transformer Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * refactor Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * correct tfexample description Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * fix test_native.py Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * add tensorflow docs and reqs Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * add tensorflow docs and reqs1 Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * tensorflow import in init Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * fix failing tests Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * add tensorflow pinned version to reqs Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * pin grpcio-status to remove protobuf error Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * add suggested changes Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * redesign transformer Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * remove old script Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * fix type reference for TFREcordDataset Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * refactor Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * refactor Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * spacing and uppercase Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * redesign with tfdir and tfrecordfile subclass Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * fix conflicts and typos Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * address majority of comments Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * refactor Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * fix test with flytefile and metadata annotated Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * fix check for example records in directory Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * refactor and correct typing Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * lint Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * import annotated from typing_extensions Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * tweak to tests to test case when Config not passed in as type Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * add suggested changes Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * add task for tfrecord dir with no config in test Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> * get filenames from local dir instead of remote Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com> Signed-off-by: Ryan Nazareth <ryankarlos@gmail.com>

Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Kevin Su <pingsutw@apache.org>

* Set default format of structured dataset to empty Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * lint Signed-off-by: Kevin Su <pingsutw@apache.org> * last error (#1364) Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Co-authored-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

* Adds pyflyte CLI reference guide Signed-off-by: Samhita Alla <aallasamhita@gmail.com> * bump python version Signed-off-by: Samhita Alla <aallasamhita@gmail.com> * bump python version Signed-off-by: Samhita Alla <aallasamhita@gmail.com> * resolve docs error Signed-off-by: Samhita Alla <aallasamhita@gmail.com> * set nested to none Signed-off-by: Samhita Alla <aallasamhita@gmail.com> * remove flyteidl version constraint Signed-off-by: Samhita Alla <aallasamhita@gmail.com> * update requirements Signed-off-by: Samhita Alla <aallasamhita@gmail.com> Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

Signed-off-by: Kevin Su <pingsutw@apache.org>

#1375) Signed-off-by: H. Furkan Vural <hfurkanvural@blackshark.ai> Implemented cache overwrite feature is added on flytekit as well for the completeness. In order to support the cache eviction RFC, an overwrite parameter was added, indicating the data store should replace an existing artifact instead of creating a new one on local calls.

…serialized context (#1378) Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

… when loading module (#1348) Signed-off-by: Ketan Umare <ketan.umare@gmail.com>

* Register databricks plugin Signed-off-by: Kevin Su <pingsutw@apache.org> * Update databricks plugin Signed-off-by: Kevin Su <pingsutw@apache.org> * register databricks Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Kevin Su <pingsutw@apache.org> Co-authored-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

For Pod tasks, if the primary_container_name is not specified, it should default. Signed-off-by: Ketan Umare <ketan.umare@gmail.com>

…for --domain (#1381) Co-authored-by: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com>

* Add support for Optional to dataclass transformer Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Add one more test Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Add one more test Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Fix serialization of optional flyte types Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> Co-authored-by: Kevin Su <pingsutw@apache.org>

* Added more pod tests and an example pod task Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * fixing test and name Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * updated Signed-off-by: Ketan Umare <ketan.umare@gmail.com> Signed-off-by: Ketan Umare <ketan.umare@gmail.com>

Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Kevin Su <pingsutw@apache.org> Co-authored-by: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com>

Signed-off-by: Patrick Brogan <pbrogan12@gmail.com>

Signed-off-by: Kevin Su <pingsutw@apache.org>

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

Signed-off-by: Kevin Su <pingsutw@apache.org>

* MLFlow plugin in progress Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * update test Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * update readme Signed-off-by: Kevin Su <pingsutw@apache.org> * lint Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * dwip Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * change experiment name Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * Add mlflow to index.rst Signed-off-by: Kevin Su <pingsutw@apache.org> * use experiment name that user provided Signed-off-by: Kevin Su <pingsutw@apache.org> * update doc-requirements.txt Signed-off-by: Kevin Su <pingsutw@apache.org> * Add backend plugin deployment Signed-off-by: Kevin Su <pingsutw@apache.org> * generate doc for method Signed-off-by: Kevin Su <pingsutw@apache.org> * lint Signed-off-by: Kevin Su <pingsutw@apache.org> * update docstring Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * update docstring Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * Update tracking.py Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> Signed-off-by: Ketan Umare <ketan.umare@gmail.com> Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> Co-authored-by: Kevin Su <pingsutw@apache.org> Co-authored-by: Niels Bantilan <niels.bantilan@gmail.com>

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* Read polars dataframe in a folder Signed-off-by: Kevin Su <pingsutw@apache.org> * Read polars dataframe in a folder Signed-off-by: Kevin Su <pingsutw@apache.org> * Load huggingface and spark plugin implicitly Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * remove _pyspark alias Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Co-authored-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* Add dummy task type to test backend plugin Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Add docs page Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Add dask models Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Add function to convert resources Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Add tests to `dask` task Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Remove namespace Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Update setup.py Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Add dask to `plugin/README.md` Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Add README.md for `dask` Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Top level export of `JopPodSpec` and `DaskCluster` Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Update docs for images Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Update README.md Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Update models after `flyteidl` change Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Update task after `flyteidl` change Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Raise error when less than 1 worker Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Update flyteidl to >= 1.3.2 Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Update doc requirements Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Update doc-requirements.txt Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Re-lock dependencies on linux Signed-off-by: Bernhard Stadlbauer <bernhard@pachama.com> * Update dask API docs Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Fix documentation links Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Default optional model constructor arguments to `None` Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Refactor `convert_resources_to_resource_model` to `core.resources` Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Use `convert_resources_to_resource_model` in `core.node` Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> * Incorporate review feedback Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Lint Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Bernhard Stadlbauer <b.stadlbauer@gmx.net> Signed-off-by: Bernhard Stadlbauer <bernhard@pachama.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

Signed-off-by: Kevin Su <pingsutw@apache.org>

* support checkpointing in local mode from cached tasks * clear cache before tests --------- Co-authored-by: Stef Nelson-Lindall <stef@stripe.com> Co-authored-by: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com>

* Deprecate FlyteSchema Signed-off-by: Kevin Su <pingsutw@apache.org> * Remove version Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Kevin Su <pingsutw@apache.org> Co-authored-by: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com>

* Use scarf images Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Use scarf names in tests. Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* add reference_launch_plan to flytekit api ref Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * import in init, add docstrings Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * add more to references Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * fix lint Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * update Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * fix up docstrings Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> --------- Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> Co-authored-by: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com> Co-authored-by: Samhita Alla <aallasamhita@gmail.com>

Signed-off-by: Kevin Su <pingsutw@apache.org>

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

* wip Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix mypy errors Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix mypy errors Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * fix test Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * Update type Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * Fix tests Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * update dev-requirements.txt Signed-off-by: Kevin Su <pingsutw@apache.org> * Address comment Signed-off-by: Kevin Su <pingsutw@apache.org> * upgrade torch Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * lint Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Kevin Su <pingsutw@gmail.com> Co-authored-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

* wip Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * add tests Signed-off-by: Kevin Su <pingsutw@apache.org> * add tests Signed-off-by: Kevin Su <pingsutw@apache.org> * support dynamic task Signed-off-by: Kevin Su <pingsutw@apache.org> * test Signed-off-by: Kevin Su <pingsutw@apache.org> * test Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * lazy compile Signed-off-by: Kevin Su <pingsutw@apache.org> * lint Signed-off-by: Kevin Su <pingsutw@apache.org> * add tests Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * test Signed-off-by: Kevin Su <pingsutw@apache.org> * test Signed-off-by: Kevin Su <pingsutw@apache.org> * lint Signed-off-by: Kevin Su <pingsutw@apache.org> * test Signed-off-by: Kevin Su <pingsutw@apache.org> * test Signed-off-by: Kevin Su <pingsutw@apache.org> * test Signed-off-by: Kevin Su <pingsutw@apache.org> * test Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * update test Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Kevin Su <pingsutw@apache.org>

* Get the origin type when serializing dataclass Signed-off-by: Kevin Su <pingsutw@apache.org> * test Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * update test Signed-off-by: Kevin Su <pingsutw@apache.org> * lint Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Kevin Su <pingsutw@apache.org> Co-authored-by: Niels Bantilan <niels.bantilan@gmail.com>

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Delay initialization of SynchronousFlyteClient in FlyteRemote Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Fix spark plugin flyteremote test. Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Lint Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

This reverts commit 3798450. Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

This reverts commit 41a9c7a. Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

codecov · 2023-02-23T00:09:42Z

Codecov Report

❗ No coverage uploaded for pull request base (release-v1.2@10bf232). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             release-v1.2    #1517   +/-   ##
===============================================
  Coverage                ?   69.31%           
===============================================
  Files                   ?      304           
  Lines                   ?    28601           
  Branches                ?     2709           
===============================================
  Hits                    ?    19826           
  Misses                  ?     8252           
  Partials                ?      523

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

eapolinario and others added 30 commits February 22, 2023 11:52

Force flyteidl==1.2.9

f0a4f68

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

Sanitize query template input in sqlite task (#1359)

5c6d0ec

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

update ray plugin dependency (#1361)

bd141f9

Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Kevin Su <pingsutw@apache.org>

Signaling (#1133)

9abc7f9

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

Adding created and updated at to ExecutionClosure model (#1371)

827be90

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

Add Databricks config to Spark Job (#1358)

567ed29

Signed-off-by: Kevin Su <pingsutw@apache.org>

Remove project/domain from being overridden with execution values in …

23dae6f

…serialized context (#1378) Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

Use TaskSpec instead of TaskTemplate for fetch_task and avoid network…

6fccbf9

… when loading module (#1348) Signed-off-by: Ketan Umare <ketan.umare@gmail.com>

PodSpec should not require primary_container name (#1380)

282b149

For Pod tasks, if the primary_container_name is not specified, it should default. Signed-off-by: Ketan Umare <ketan.umare@gmail.com>

fix(pyflyte): change -d to -D for --destination-dir as -d is already …

a21ba24

…for --domain (#1381) Co-authored-by: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com>

add FastSerializationSettings to docs (#1386)

d84c13c

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> Co-authored-by: Kevin Su <pingsutw@apache.org>

Convert default dict to json string in pyflyte run (#1399)

bfc2b15

Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Kevin Su <pingsutw@apache.org> Co-authored-by: Eduardo Apolinario <653394+eapolinario@users.noreply.github.com>

docs: update register help, non-fast version is supported (#1402)

42c89dd

Signed-off-by: Patrick Brogan <pbrogan12@gmail.com>

Update log level for structured dataset (#1394)

cd69fc5

Signed-off-by: Kevin Su <pingsutw@apache.org>

Add Niels to code owners (#1404)

f25cf67

Signed-off-by: Kevin Su <pingsutw@apache.org>

Signal use (#1398)

0f3f468

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

User Documentation Proposal (#1200)

3f700ff

Signed-off-by: Kevin Su <pingsutw@apache.org>

fix remote API reference (#1405)

8061d8b

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

Update default config to work out-of-the-box with flytectl demo (#1384)

25fe341

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

Add support for overriding task configurations (#1410)

74ba98b

Signed-off-by: Kevin Su <pingsutw@apache.org>

bethebunny and others added 9 commits February 22, 2023 14:21

Use non-root user in default flytekit image (#1417)

9de0288

Signed-off-by: Kevin Su <pingsutw@apache.org>

Fix PyTorch transformer (#1510)

3b5e9eb

Signed-off-by: Samhita Alla <aallasamhita@gmail.com>

eapolinario requested review from kumare3, pingsutw and wild-endeavor as code owners February 22, 2023 22:29

wild-endeavor previously approved these changes Feb 22, 2023

View reviewed changes

eapolinario and others added 3 commits February 22, 2023 14:39

Fix bad merge

3e37177

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

Set flytekit and flyteidl bounds in plugins tests

01ba21a

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

eapolinario dismissed wild-endeavor’s stale review via 01ba21a February 22, 2023 23:16

eapolinario added 6 commits February 22, 2023 15:26

Revert "Fix mypy errors (#1313)"

dd79a11

This reverts commit 3798450. Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

Fix requirements in dask and ray plugins

d2a002c

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

Fix papermill tests requirements

d9d94d5

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

Fix doc-requirements

3e23781

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

dask plugin requirements

ecea6cb

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

Revert "Add dask plugin #patch (#1366)"

abfcbb4

This reverts commit 41a9c7a. Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

eapolinario added 4 commits February 22, 2023 16:16

Fix deck-standard test

b9492da

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

Fix great-expectations requirements

87bbd6f

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

Fix onnx-tensorflow requirements

052ea88

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

Fix sqlalchemy requirements

2277366

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

wild-endeavor approved these changes Feb 23, 2023

View reviewed changes

eapolinario merged commit d75c800 into release-v1.2 Feb 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Backporting changes to release-v1.2#1517

Backporting changes to release-v1.2#1517
eapolinario merged 67 commits into
release-v1.2from
backporting-v1.2.8

eapolinario commented Feb 22, 2023 •

edited

Loading

Uh oh!

codecov Bot commented Feb 23, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

Uh oh!

Conversation

eapolinario commented Feb 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TL;DR

Uh oh!

codecov Bot commented Feb 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

eapolinario commented Feb 22, 2023 •

edited

Loading

codecov Bot commented Feb 23, 2023 •

edited

Loading