Propagate ca_cert_file_path and verify settings to auth client#1509
Propagate ca_cert_file_path and verify settings to auth client#1509goyalankit wants to merge 2 commits into
Conversation
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Signed-off-by: Ankit Goyal <angoyal@linkedin.com>
Codecov Report
@@ Coverage Diff @@
## master #1509 +/- ##
==========================================
- Coverage 69.45% 69.43% -0.02%
==========================================
Files 305 305
Lines 28581 28590 +9
Branches 2699 2701 +2
==========================================
+ Hits 19850 19851 +1
- Misses 8213 8221 +8
Partials 518 518
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@goyalankit I have this PR in progress, that completely overhauls the auth subsystem - #1458 |
Got it.. but this is still valid? I can close my PR if you want to take these changes into account in your PR? The main issue is that we are not passing the |
Co-authored-by: Kevin Su <pingsutw@gmail.com> Signed-off-by: Ankit Goyal <angoyal@linkedin.com>
|
Closing as the changes have been incorporated in #1458 |
TL;DR
Propagate ca_cert_file_path and verify settings to auth client
Flytekit throws
CERTIFICATE_VERIFY_FAILEDon auth even if user has specified the certificate path or has setinsecureSkipVerifytoFalse. This change adds theverifyto requests library according to user configured settings.Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/