WIP - Detect if running on a Mac M1 and use appropriate dev-requirements file#1424
Closed
eapolinario wants to merge 4 commits into
Closed
WIP - Detect if running on a Mac M1 and use appropriate dev-requirements file#1424eapolinario wants to merge 4 commits into
eapolinario wants to merge 4 commits into
Conversation
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
eapolinario
requested review from
cosmicBboy,
kumare3,
pingsutw and
wild-endeavor
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1424 +/- ##
==========================================
+ Coverage 69.20% 69.24% +0.03%
==========================================
Files 300 300
Lines 28114 28146 +32
Branches 2646 2649 +3
==========================================
+ Hits 19457 19490 +33
+ Misses 8143 8142 -1
Partials 514 514
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
eapolinario
changed the title
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
2 tasks
Collaborator
Author
|
Superseded by #1511. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eduardo Apolinario eapolinario@users.noreply.github.com
Fixes flyteorg/flyte#3264
TL;DR
Special case Mac M1/2's in the case of dev environment
Type
Are all requirements met?
Complete description
In this PR the make targets related to the dev environment detect if the user's platform. We introduce a new dev-requirements file produced on a Mac M1.
Testing:
make dev-requirements.txton a M1 and push a commit to this PR with the contents of thedev-requirements-mac_arm64.txtfile.make setupon a new venvTracking Issue
flyteorg/flyte#3264
Follow-up issue
NA