pr into #1384#1407
Merged
Merged
Conversation
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## update-default-config #1407 +/- ##
=========================================================
+ Coverage 69.17% 69.18% +0.01%
=========================================================
Files 299 296 -3
Lines 28008 27774 -234
Branches 2631 2612 -19
=========================================================
- Hits 19374 19216 -158
+ Misses 8120 8048 -72
+ Partials 514 510 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
cosmicBboy
approved these changes
Jan 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see the other PR.
This one:
~/.flyte/config-sandbox.ymlfile but I think using the code option is a bit cleaner, even though it ties us closer to the flytectl demo port settings.