-
Notifications
You must be signed in to change notification settings - Fork 338
Add dask plugin #patch #1366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add dask plugin #patch #1366
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
eddb152
Add dummy task type to test backend plugin
bstadlbauer 407d5cb
Add docs page
bstadlbauer 992d5e7
Add dask models
bstadlbauer d7bdf47
Add function to convert resources
bstadlbauer 641d2ac
Add tests to `dask` task
bstadlbauer 96162bf
Remove namespace
bstadlbauer 6092b6f
Update setup.py
bstadlbauer 1caceff
Add dask to `plugin/README.md`
bstadlbauer afa54df
Add README.md for `dask`
bstadlbauer 49bdab3
Top level export of `JopPodSpec` and `DaskCluster`
bstadlbauer 96270f3
Update docs for images
bstadlbauer dfc4131
Update README.md
bstadlbauer de2af6d
Update models after `flyteidl` change
bstadlbauer 8633ecc
Update task after `flyteidl` change
bstadlbauer 528a085
Merge remote-tracking branch 'origin/master' into add-dask-plugin
bstadlbauer 019529d
Raise error when less than 1 worker
bstadlbauer b04fb3d
Update flyteidl to >= 1.3.2
bstadlbauer 4d5e445
Update doc requirements
bstadlbauer a5311ae
Merge branch 'master' into add-dask-plugin
bstadlbauer f703c09
Update doc-requirements.txt
bstadlbauer 0465291
Re-lock dependencies on linux
f02d9dc
Update dask API docs
bstadlbauer b50be3e
Merge branch 'master' into add-dask-plugin
bstadlbauer 167d654
Fix documentation links
bstadlbauer dab1bc6
Default optional model constructor arguments to `None`
bstadlbauer 3722b0a
Refactor `convert_resources_to_resource_model` to `core.resources`
bstadlbauer 4f829b7
Use `convert_resources_to_resource_model` in `core.node`
bstadlbauer 43147cb
Merge branch 'master' into add-dask-plugin
bstadlbauer 1e6e3e1
Merge branch 'master' into add-dask-plugin
eapolinario aadf78c
Incorporate review feedback
eapolinario 8c62437
Lint
eapolinario File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| .. _dask: | ||
|
|
||
| ################################################### | ||
| Dask API reference | ||
| ################################################### | ||
|
|
||
| .. tags:: Integration, DistributedComputing, KubernetesOperator | ||
|
|
||
| .. automodule:: flytekitplugins.dask | ||
| :no-members: | ||
| :no-inherited-members: | ||
| :no-special-members: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| # Flytekit Dask Plugin | ||
|
|
||
| Flyte can execute `dask` jobs natively on a Kubernetes Cluster, which manages the virtual `dask` cluster's lifecycle | ||
| (spin-up and tear down). It leverages the open-source Kubernetes Dask Operator and can be enabled without signing up | ||
| for any service. This is like running a transient (ephemeral) `dask` cluster - a type of cluster spun up for a specific | ||
| task and torn down after completion. This helps in making sure that the Python environment is the same on the job-runner | ||
| (driver), scheduler and the workers. | ||
|
|
||
| To install the plugin, run the following command: | ||
|
|
||
| ```bash | ||
| pip install flytekitplugins-dask | ||
| ``` | ||
|
|
||
| To configure Dask in the Flyte deployment's backed, follow | ||
| [step 1](https://docs.flyte.org/projects/cookbook/en/latest/auto/integrations/kubernetes/k8s_dask/index.html#step-1-deploy-the-dask-plugin-in-the-flyte-backend) | ||
| and | ||
| [step 2](https://docs.flyte.org/projects/cookbook/en/latest/auto/auto/integrations/kubernetes/k8s_dask/index.html#step-2-environment-setup) | ||
|
|
||
| An [example](https://docs.flyte.org/projects/cookbook/en/latest/auto/integrations/kubernetes/k8s_dask/index.html) | ||
| can be found in the documentation. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we add one line about what happens in local execution? |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| """ | ||
| .. currentmodule:: flytekitplugins.dask | ||
|
|
||
| This package contains the Python related side of the Dask Plugin | ||
|
|
||
| .. autosummary:: | ||
| :template: custom.rst | ||
| :toctree: generated/ | ||
|
|
||
| Dask | ||
| Scheduler | ||
| WorkerGroup | ||
| """ | ||
|
|
||
| from flytekitplugins.dask.task import Dask, Scheduler, WorkerGroup |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.