3006 - Added a version constraint for grpcio and grpcio-status#1248
Merged
eapolinario merged 2 commits intoOct 20, 2022
Merged
Conversation
dennisobrien
requested review from
eapolinario,
kumare3,
pingsutw and
wild-endeavor
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1248 +/- ##
========================================
Coverage 68.68% 68.68%
========================================
Files 288 288
Lines 26333 26333
Branches 2942 2486 -456
========================================
Hits 18087 18087
Misses 7768 7768
Partials 478 478 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Collaborator
|
Can you run |
…er to prevent an incompatible verison of protobuf. Signed-off-by: Dennis O'Brien <dennis@dennisobrien.net>
….txt Signed-off-by: Dennis O'Brien <dennis@dennisobrien.net>
dennisobrien
force-pushed
the
dennisobrien.3006.add_version_constraint_for_grpcio
branch
from
9af3255 to
6633303
Compare
eapolinario
approved these changes
Oct 20, 2022
8 tasks
8 tasks
VPraharsha03
pushed a commit
to VPraharsha03/flytekit
that referenced
this pull request
Oct 23, 2022
…org#1248) * 3006 - Added a version constraint for grpcio and grpcio-status in order to prevent an incompatible verison of protobuf. Signed-off-by: Dennis O'Brien <dennis@dennisobrien.net> * Generated requirements-spark2.txt by running make requirements-spark2.txt Signed-off-by: Dennis O'Brien <dennis@dennisobrien.net> Signed-off-by: Dennis O'Brien <dennis@dennisobrien.net> Signed-off-by: Vivek Praharsha <vpraharsha@outlook.com>
Contributor
|
@dennisobrien, please fill in this form to claim your swag. |
VPraharsha03
pushed a commit
to VPraharsha03/flytekit
that referenced
this pull request
Oct 29, 2022
…org#1248) * 3006 - Added a version constraint for grpcio and grpcio-status in order to prevent an incompatible verison of protobuf. Signed-off-by: Dennis O'Brien <dennis@dennisobrien.net> * Generated requirements-spark2.txt by running make requirements-spark2.txt Signed-off-by: Dennis O'Brien <dennis@dennisobrien.net> Signed-off-by: Dennis O'Brien <dennis@dennisobrien.net>
kiliangojek
pushed a commit
to kiliangojek/flytekit
that referenced
this pull request
Nov 15, 2022
…org#1248) * 3006 - Added a version constraint for grpcio and grpcio-status in order to prevent an incompatible verison of protobuf. Signed-off-by: Dennis O'Brien <dennis@dennisobrien.net> * Generated requirements-spark2.txt by running make requirements-spark2.txt Signed-off-by: Dennis O'Brien <dennis@dennisobrien.net> Signed-off-by: Dennis O'Brien <dennis@dennisobrien.net> Signed-off-by: Kilian <kilian.tep@go-jek.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Added a version constraint for
grpcioandgrpcio-statusin order to prevent an incompatible verison ofprotobuf.The latest version of
grpcio(1.50.0) requires a version ofprotobuf>= 4.0 that is not compatible with this project. This causes a failure when runningmake dev-requirements.txt. To fix this, we add a version constraint ongrpcioandgrpcio-status.Type
Are all requirements met?
Complete description
This was fixed by adding version constraints for
grpcioandgrpcio-statusinrequirements.in.This was originally discussed in this slack thread.
This may be a temporary solution as there was mention of updating the protobuf dependency.
Tracking Issue
flyteorg/flyte#3006