Skip to content
This repository was archived by the owner on May 31, 2024. It is now read-only.

update flytectl for new navbar#259

Merged
cosmicBboy merged 1 commit into
masterfrom
docs/2028
Jan 8, 2022
Merged

update flytectl for new navbar#259
cosmicBboy merged 1 commit into
masterfrom
docs/2028

Conversation

@cosmicBboy

@cosmicBboy cosmicBboy commented Jan 7, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: Niels Bantilan niels.bantilan@gmail.com

TL;DR

This PR should be merged with the following other PRs in order to update the theme to use the navbar header:

Type

  • Bug Fix
  • Feature
  • Plugin
  • Docs

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
@codecov

codecov Bot commented Jan 7, 2022

Copy link
Copy Markdown

Codecov Report

Merging #259 (3422ebf) into master (ce1c5f4) will increase coverage by 5.35%.
The diff coverage is 76.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
+ Coverage   76.17%   81.53%   +5.35%     
==========================================
  Files         106       93      -13     
  Lines        2695     3406     +711     
==========================================
+ Hits         2053     2777     +724     
+ Misses        528      415     -113     
- Partials      114      214     +100     
Impacted Files Coverage Δ
cmd/completion.go 90.90% <ø> (ø)
cmd/config/config.go 66.66% <ø> (ø)
cmd/create/create.go 100.00% <ø> (ø)
cmd/get/matchable_cluster_resource_attribute.go 100.00% <ø> (ø)
cmd/get/matchable_execution_cluster_label.go 100.00% <ø> (ø)
cmd/get/matchable_execution_queue_attribute.go 100.00% <ø> (ø)
cmd/get/matchable_plugin_override.go 100.00% <ø> (ø)
cmd/get/matchable_task_resource_attribute.go 100.00% <ø> (ø)
cmd/get/project.go 86.36% <ø> (+3.03%) ⬆️
cmd/register/register.go 100.00% <ø> (ø)
... and 160 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebdf545...3422ebf. Read the comment docs.

@cosmicBboy cosmicBboy merged commit d20ef0c into master Jan 8, 2022
@cosmicBboy cosmicBboy deleted the docs/2028 branch January 8, 2022 00:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants