This repository was archived by the owner on May 31, 2024. It is now read-only.
update flytectl for new navbar#259
Merged
Merged
Conversation
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
This was referenced Jan 7, 2022
EngHabu
approved these changes
Jan 7, 2022
Codecov Report
@@ Coverage Diff @@
## master #259 +/- ##
==========================================
+ Coverage 76.17% 81.53% +5.35%
==========================================
Files 106 93 -13
Lines 2695 3406 +711
==========================================
+ Hits 2053 2777 +724
+ Misses 528 415 -113
- Partials 114 214 +100
Continue to review full report at Codecov.
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Niels Bantilan niels.bantilan@gmail.com
TL;DR
This PR should be merged with the following other PRs in order to update the theme to use the navbar header:
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/