This repository was archived by the owner on Oct 9, 2023. It is now read-only.
Remove content md5 requirement#587
Merged
Merged
Conversation
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #587 +/- ##
==========================================
+ Coverage 58.58% 60.22% +1.63%
==========================================
Files 168 168
Lines 16262 13312 -2950
==========================================
- Hits 9527 8017 -1510
+ Misses 5893 4445 -1448
- Partials 842 850 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
wild-endeavor
requested review from
EngHabu,
eapolinario,
hamersaw,
katrogan,
kumare3 and
pmahindrakar-oss
as code owners
wild-endeavor
changed the title
EngHabu
previously approved these changes
Jul 10, 2023
| if err != nil { | ||
| return nil, errors.NewFlyteAdminErrorf(codes.Internal, "failed to check if file exists at location [%s], Error: %v", knownLocation.String(), err) | ||
| } | ||
| if metadata.Exists() { |
Contributor
There was a problem hiding this comment.
Let's add a comment that this is best effort and acknowledge the racing issue?
8 tasks
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Contributor
Author
|
@EngHabu bumped stdlib and added comment.... one more look whenever you get a chance please? |
EngHabu
approved these changes
Jul 13, 2023
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Remove the requirement that content md5 is provided.
Depends on flyteorg/flytestdlib#160
Type
Are all requirements met?
Complete description
If the full native path is fully specified, not random, then we check to see if it exists.
If it exists then the user needs to have given a hash, which admin will check against the etags.
etags are computed differently for different stores, so we try a few different ways.
if the tag doesn't match, then we error. if no hash was given then also error.
Tracking Issue
This is related to flyteorg/flytekit#1674