Make fetching HttpClient optional from context in PKCE auth flow#4295
Merged
Conversation
Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com>
eapolinario
reviewed
Oct 24, 2023
Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com>
eapolinario
previously approved these changes
Oct 24, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4295 +/- ##
===========================================
+ Coverage 58.73% 78.96% +20.23%
===========================================
Files 583 18 -565
Lines 50331 1298 -49033
===========================================
- Hits 29562 1025 -28537
+ Misses 18396 209 -18187
+ Partials 2373 64 -2309
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com>
Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com>
pmahindrakar-oss
marked this pull request as ready for review
October 24, 2023 22:32
eapolinario
approved these changes
Oct 24, 2023
eapolinario
left a comment
Contributor
There was a problem hiding this comment.
Thanks for adding the unit test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Describe your changes
Previous PR introduced authentication with proxy http Client but it added a hard dependency to fetch this from the context .
This causes regression in cases the context is not set with this object.
Current change makes it backward compatible by using the default http client in case the context is not set with it.
Check all the applicable boxes
Tested this change locally by pulling this commit as saw authentication working fine in the broken environments
Screenshots
Note to reviewers