Return ResourceWrapper without pointer#4115
Merged
Merged
Conversation
Signed-off-by: Kevin Su <pingsutw@apache.org>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4115 +/- ##
==========================================
+ Coverage 58.98% 59.31% +0.33%
==========================================
Files 618 549 -69
Lines 52708 39609 -13099
==========================================
- Hits 31088 23493 -7595
+ Misses 19140 13800 -5340
+ Partials 2480 2316 -164
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Kevin Su <pingsutw@apache.org>
This reverts commit 1e482f2.
wild-endeavor
approved these changes
Oct 3, 2023
EngHabu
approved these changes
Oct 4, 2023
This was referenced Oct 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Worker in async cache panics because it fails to cast resource to
*ResourceWrappercache (*Resource) -> cast to (*Resource) // it works
s3 (Resource) -> cast to (*Resource) // Failed to do type casting since we unmarshall the resource to
Resourcehere.We read the resource from s3 bucket after restarting the propeller (cache becomes empty).
Type
Are all requirements met?
Complete description
^^^
Tracking Issue
NA
Follow-up issue
NA