-
Notifications
You must be signed in to change notification settings - Fork 1
Session host #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Session host #139
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
a496ae9
Docs: add RMG view protocol task checklist
flyingrobots f8b841a
CI: mirror audit ignores into ci.yml
flyingrobots 12a4619
Fix cargo audit args folding in ci.yml
flyingrobots a44c9e3
Policy: allow zlib, OFL, Ubuntu-font, MPL in cargo-deny
flyingrobots File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| <!-- SPDX-License-Identifier: Apache-2.0 OR MIND-UCAL-1.0 --> | ||
| <!-- © James Ross Ω FLYING•ROBOTS <https://github.com/flyingrobots> --> | ||
| # RMG View Protocol Tasks | ||
|
|
||
| - [ ] Define the “RMG View Protocol” package: channel naming, RmgId + owner identity, publisher-only writes, message pattern (snapshot + diff, gapless epochs, hashes/acks), transport (canonical CBOR, MAX_PAYLOAD, non-blocking). | ||
| - [ ] Generalize as an Echo Interaction Pattern (EIP) template capturing roles, authority, message types, flow styles (req/resp, pub/sub, bidir), reliability/validation hooks for future services. | ||
| - [ ] Enforce authority: session-service rejects non-owner writes on the RMG channel; client surfaces errors. | ||
| - [ ] Dirty-flag sync loop in viewer: mark dirty on mutation, publish snapshot/diff on net tick when dirty, clear on ack; throttle/batch as needed. | ||
| - [ ] Publish/subscribe toggles in UI: enable/disable sending my RMG and receiving per RmgId, preserving epoch/hash continuity when re-enabled. | ||
| - [ ] Session-service wiring: add publish endpoint, validate owner + gapless epochs/hashes, rebroadcast to other subscribers; explicit error codes. | ||
| - [ ] Client wiring: implement publish call + retry/backoff; handle authority/hash errors and resync requests. | ||
| - [ ] Demo path: script/doc for one session-service + two viewers (one publisher, one subscriber) showing shared RMG changes. | ||
| - [ ] Tests: protocol conformance (authority rejection, gapless enforcement, dirty-loop behavior, toggle respect) and integration test with two clients + server loopback. | ||
| - [ ] Docs sync: update execution-plan intents and decision-log entries as slices land. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: flyingrobots/echo
Length of output: 72
🏁 Script executed:
Repository: flyingrobots/echo
Length of output: 88
🏁 Script executed:
Repository: flyingrobots/echo
Length of output: 116
🏁 Script executed:
Repository: flyingrobots/echo
Length of output: 1806
🏁 Script executed:
Repository: flyingrobots/echo
Length of output: 42351
🏁 Script executed:
Repository: flyingrobots/echo
Length of output: 37400
🏁 Script executed:
Repository: flyingrobots/echo
Length of output: 920
🏁 Script executed:
Repository: flyingrobots/echo
Length of output: 774
🏁 Script executed:
Repository: flyingrobots/echo
Length of output: 165
🏁 Script executed:
Repository: flyingrobots/echo
Length of output: 1401
🏁 Script executed:
Repository: flyingrobots/echo
Length of output: 43
🏁 Script executed:
Repository: flyingrobots/echo
Length of output: 801
Add RUSTSEC-2021-0127 to the advisories ignore list and document rationale for new licenses.
Lines 19–22 add four new licenses ("Zlib", "OFL-1.1", "Ubuntu-font-1.0", "MPL-2.0") without justification. Additionally,
deny.tomlomits RUSTSEC-2021-0127 from the advisories section despite both GitHub workflows (security-audit.yml and ci.yml) ignoring it. This creates two problems:Incomplete advisory policy: RUSTSEC-2021-0127 (serde_cbor legacy advisory) is suppressed in CI workflows but missing from deny.toml, which should be the single source of truth for dependency policies.
Undocumented license allowlist: No rationale exists for the four new licenses. Compare to line 43–45, which provides essential context (wgpu/paste unmaintainedness). Each new license needs documented:
Add RUSTSEC-2021-0127 to lines 42–46 and precede lines 19–22 with a comment block explaining the license rationale:
[advisories] ignore = [ # wgpu transitively depends on paste 1.0.15; upstream is unmaintained but # tracked in wgpu#5185. Safe to ignore until wgpu publishes a replacement. "RUSTSEC-2024-0436", + # serde_cbor is a legacy dependency with an unmaintained advisory; ignoring + # prevents CI flakiness if re-introduced through cached lockfiles. + "RUSTSEC-2021-0127", ]📝 Committable suggestion