Skip to content

feat(package_info_plus): Added toMap method #1926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nohli merged 10 commits into from
Jun 29, 2023
Merged

feat(package_info_plus): Added toMap method #1926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a67e603
[package_info_plus] add toMap
mattiacorbelli Jun 23, 2023
fdf92b8
[package_info_plus] removed null/empty values
mattiacorbelli Jun 23, 2023
d4e9b6e
[package_info_plus] fix nullable value
mattiacorbelli Jun 23, 2023
fda929f
[package_info_plus] fix missing character
mattiacorbelli Jun 23, 2023
8202d13
[package_info_plus] local variable converted to final
mattiacorbelli Jun 23, 2023
d8afce9
[package_info_plus] added getter in favor of toMap
mattiacorbelli Jun 24, 2023
f800a6d
Update packages/package_info_plus/package_info_plus/lib/package_info_…
mcorbelli Jun 25, 2023
87edf33
Merge branch 'main' into main
nohli Jun 26, 2023
9e5722b
added tests toMap
mattiacorbelli Jun 26, 2023
155ef4c
Format
nohli Jun 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/package_info_plus/package_info_plus/lib/package_info_plus.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,4 +119,18 @@ class PackageInfo {
String toString() {
return 'PackageInfo(appName: $appName, buildNumber: $buildNumber, packageName: $packageName, version: $version, buildSignature: $buildSignature, installerStore: $installerStore)';
}

Map<String, dynamic> _toMap() {
return {
'appName': appName,
'buildNumber': buildNumber,
'packageName': packageName,
'version': version,
if (buildSignature.isNotEmpty) 'buildSignature': buildSignature,
if (installerStore?.isNotEmpty ?? false) 'installerStore': installerStore,
};
}

/// Gets a map representation of the [PackageInfo] instance.
Map<String, dynamic> get data => _toMap();
}
100 changes: 70 additions & 30 deletions packages/package_info_plus/package_info_plus/test/package_info_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,51 +75,91 @@ void main() {

test('equals checks for value equality', () async {
final info1 = PackageInfo(
appName: 'package_info_example',
buildNumber: '1',
packageName: 'io.flutter.plugins.packageinfoexample',
version: '1.0',
buildSignature: '',
installerStore: null);
appName: 'package_info_example',
buildNumber: '1',
packageName: 'io.flutter.plugins.packageinfoexample',
version: '1.0',
buildSignature: '',
installerStore: null,
);
final info2 = PackageInfo(
appName: 'package_info_example',
buildNumber: '1',
packageName: 'io.flutter.plugins.packageinfoexample',
version: '1.0',
buildSignature: '',
installerStore: null);
appName: 'package_info_example',
buildNumber: '1',
packageName: 'io.flutter.plugins.packageinfoexample',
version: '1.0',
buildSignature: '',
installerStore: null,
);
expect(info1, info2);
});

test('hashCode checks for value equality', () async {
final info1 = PackageInfo(
appName: 'package_info_example',
buildNumber: '1',
packageName: 'io.flutter.plugins.packageinfoexample',
version: '1.0',
buildSignature: '',
installerStore: null);
appName: 'package_info_example',
buildNumber: '1',
packageName: 'io.flutter.plugins.packageinfoexample',
version: '1.0',
buildSignature: '',
installerStore: null,
);
final info2 = PackageInfo(
appName: 'package_info_example',
buildNumber: '1',
packageName: 'io.flutter.plugins.packageinfoexample',
version: '1.0',
buildSignature: '',
installerStore: null);
appName: 'package_info_example',
buildNumber: '1',
packageName: 'io.flutter.plugins.packageinfoexample',
version: '1.0',
buildSignature: '',
installerStore: null,
);
expect(info1.hashCode, info2.hashCode);
});

test('toString returns a string representation', () async {
final info = PackageInfo(
appName: 'package_info_example',
buildNumber: '1',
packageName: 'io.flutter.plugins.packageinfoexample',
version: '1.0',
buildSignature: '',
installerStore: null);
appName: 'package_info_example',
buildNumber: '1',
packageName: 'io.flutter.plugins.packageinfoexample',
version: '1.0',
buildSignature: '',
installerStore: null,
);
expect(
info.toString(),
'PackageInfo(appName: package_info_example, buildNumber: 1, packageName: io.flutter.plugins.packageinfoexample, version: 1.0, buildSignature: , installerStore: null)',
);
});

test('data returns a map representation', () async {
PackageInfo.setMockInitialValues(
appName: 'mock_package_info_example',
packageName: 'io.flutter.plugins.mockpackageinfoexample',
version: '1.1',
buildNumber: '2',
buildSignature: '',
installerStore: null,
);
final info1 = await PackageInfo.fromPlatform();
expect(info1.data, {
'appName': 'mock_package_info_example',
'packageName': 'io.flutter.plugins.mockpackageinfoexample',
'version': '1.1',
'buildNumber': '2',
});
PackageInfo.setMockInitialValues(
appName: 'mock_package_info_example',
packageName: 'io.flutter.plugins.mockpackageinfoexample',
version: '1.1',
buildNumber: '2',
buildSignature: 'deadbeef',
installerStore: 'testflight',
);
final info2 = await PackageInfo.fromPlatform();
expect(info2.data, {
'appName': 'mock_package_info_example',
'packageName': 'io.flutter.plugins.mockpackageinfoexample',
'version': '1.1',
'buildNumber': '2',
'buildSignature': 'deadbeef',
'installerStore': 'testflight',
});
});
}