plugins: fix compilation if FLB_SQLDB (sqlite3) is disabled by ThomasDevoogdt · Pull Request #10239 · fluent/fluent-bit

ThomasDevoogdt · 2025-04-22T20:42:16Z

Fixes:

Building without FLB_SQLDB (sqlite3) support completely broken. #9757.

Summary by CodeRabbit

New Features
- SQLDB support is now optional; enabling it restores partial-match checklist behavior and improved blob upload tracking.
- Added a new post-upload action: "Add Suffix".
Bug Fixes
- Non-database builds now fail fast for DB-only modes/events to avoid unexpected behavior.
- Improved initialization and cleanup to prevent leftover state on failures.
Tests
- CI and unit tests now run with DB-enabled and DB-disabled variants; DB-only tests are conditional.

patrick-stephens · 2025-04-24T08:48:02Z

Let's make sure this compiles for all existing targets as well.

Would it be better to disable the features within the plugins that need the DB rather than the whole plugin @leonardo-albertovich ? It feels a bit like a large hammer, e.g. no tail input even if you don't use db. We would have to make the config options and any other usage conditional though so it may be worse.

ThomasDevoogdt · 2025-04-24T20:49:03Z

Let's make sure this compiles for all existing targets as well.

How can it not? Currently, FLB_SQLDB is enabled by default, and will stay like that. The problem is the other way around, if not enabled, then compilation breaks.

Would it be better to disable the features within the plugins that need the DB rather than the whole plugin @leonardo-albertovich ? It feels a bit like a large hammer, e.g. no tail input even if you don't use db. We would have to make the config options and any other usage conditional though so it may be worse.

For me fine, but I would do that on a per feature basis. Perhaps just continue with this PR, and then fine-tune some features that might compile with some small fixups.

In general, it would be much better if all options are toggled in the automated tests, on one reference compilation system. Perhaps even by incremental builds. But either way, I just want to fix compilation now.

ThomasDevoogdt · 2025-05-02T11:56:50Z

@patrick-stephens @edsiper I changed this PR so that plugins are still compiled, but without database support. I hope this answers #10239 (comment).

Tested by doing this:

cd build/
cmake -GNinja -DFLB_SQLDB=OFF ../
ninja

and

cd build/
cmake -GNinja -DFLB_PREFER_SYSTEM_LIBS=ON -DFLB_SQLDB=OFF ../
ninja

patrick-stephens · 2025-05-02T18:46:02Z

Not sure if the CI failure is relevant or something else

ThomasDevoogdt · 2025-05-02T22:52:52Z

Not sure if the CI failure is relevant or something else

I just added #ifdef FLB_HAVE_SQLDB, which is true by default, so I don't think it's relevant.

patrick-stephens · 2025-11-21T12:47:42Z

@leonardo-albertovich just checking your comments were covered?

leonardo-albertovich · 2025-11-21T19:44:14Z

I'll review this PR again tomorrow. @ThomasDevoogdt if you have any questions that were unanswered (I think I missed some) please repeat them so I can address them tomorrow.

ThomasDevoogdt · 2025-11-21T21:17:49Z

I'll review this PR again tomorrow. @ThomasDevoogdt if you have any questions that were unanswered (I think I missed some) please repeat them so I can address them tomorrow.

I don't have any open questions. If you see any shortcomings in this PR, then I will try to address them. But beware that I won't do any in depth refactorings, for that, someone closser to the matter should step in.

ThomasDevoogdt · 2025-11-25T19:45:44Z

I'll review this PR again tomorrow. @ThomasDevoogdt if you have any questions that were unanswered (I think I missed some) please repeat them so I can address them tomorrow.

@leonardo-albertovich I think this PR is finalized, it would be nice having it merged. By this, the runtime tests would also start to work, limiting the chance that I have to rework this anytime soon.

leonardo-albertovich · 2025-11-26T13:27:40Z

I don't have merge privileges anymore so you should ask @edsiper about it and wait for him to have time to dedicate to this.

ThomasDevoogdt · 2025-12-05T14:26:58Z

@edsiper @patrick-stephens ping ...

ThomasDevoogdt · 2025-12-22T09:15:15Z

@edsiper @patrick-stephens ping ...

Hi, this week is perhaps the ideal moment to merge it? @edsiper

ThomasDevoogdt · 2025-12-22T17:54:36Z

@patrick-stephens Thx for the approval, can you also merge this?

ThomasDevoogdt · 2026-01-05T12:56:47Z

@patrick-stephens @edsiper Happy New Year! 🎉

It's perhaps the ideal moment to merge this pull request now.

ThomasDevoogdt · 2026-01-14T18:33:23Z

@patrick-stephens @edsiper Again a week later. Can this be merged please?

ThomasDevoogdt · 2026-01-19T20:19:44Z

@patrick-stephens @edsiper ping

ThomasDevoogdt · 2026-01-27T22:06:55Z

@patrick-stephens @edsiper @cosmo0920 ping

patrick-stephens · 2026-01-28T14:26:39Z

@leonardo-albertovich I think you are happy the changes are done?

leonardo-albertovich · 2026-02-04T15:57:22Z

IIRC it looked fine but I deferred to Eduardo on this one.

ThomasDevoogdt · 2026-02-15T10:23:24Z

@edsiper @leonardo-albertovich @patrick-stephens @cosmo0920 And any other maintainer, I can understand that this doesn't have a high priority, but how much patience do you expect me to have? It takes months and months until I get a proper review, and in the end an approve, to then get buried in the Fluent Bit Next graveyard. I'm fine with applying fixes to maintain fluent-bit in Buildroot, I also saw many of my commits and proposal being reused by other package maintainers, so I guess that they are somewhat worth it. So I would appreciate it that also this one gets merged over time.

E.g. Upstream usage of the FLB_PREFER_SYSTEM_LIB(S) usage:

openbmc
tenzir
azurelinux
buildroot (Which I maintain)

ThomasDevoogdt · 2026-03-05T21:02:27Z

@celalettin1286 @cosmo0920 @edsiper @niedbalski @patrick-stephens Can anyone review this pull request, and finally also merge this?

ThomasDevoogdt · 2026-03-25T13:18:19Z

@celalettin1286 @cosmo0920 @edsiper @niedbalski @patrick-stephens ping ...

Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>

ThomasDevoogdt · 2026-04-21T10:07:02Z

@celalettin1286 @cosmo0920 @edsiper @niedbalski @patrick-stephens ping again ...

How many times do I still have to rebase this until someone merges this PR? This PR is a year old! I'm starting to loose my patience here.

…AVE_SQLDB Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>

Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>

ThomasDevoogdt · 2026-04-30T09:04:39Z

@leonardo-albertovich ping

ThomasDevoogdt · 2026-05-28T22:14:25Z

@leonardo-albertovich ping

patrick-stephens · 2026-06-02T09:01:27Z

This is fine by me so will ping @cosmo0920 , I don't think @leonardo-albertovich has time for this at the moment

ThomasDevoogdt · 2026-06-11T17:26:55Z

@patrick-stephens oké

ThomasDevoogdt requested review from edsiper, fujimotos, koleini and leonardo-albertovich as code owners April 22, 2025 20:42

github-actions Bot added the docs-required label Apr 22, 2025

ThomasDevoogdt mentioned this pull request Apr 22, 2025

Building without FLB_SQLDB (sqlite3) support completely broken. #9757

Closed

ThomasDevoogdt force-pushed the bugfix/sqlite3-disabled branch from 4b2f2ad to a767a54 Compare April 23, 2025 09:43

patrick-stephens added ok-package-test Run PR packaging tests and removed docs-required labels Apr 24, 2025

ThomasDevoogdt force-pushed the bugfix/sqlite3-disabled branch from a767a54 to 8cf7987 Compare May 2, 2025 11:53

ThomasDevoogdt temporarily deployed to pr May 2, 2025 11:54 — with GitHub Actions Inactive

ThomasDevoogdt force-pushed the bugfix/sqlite3-disabled branch from 8cf7987 to 7092bc1 Compare May 2, 2025 11:54

ThomasDevoogdt temporarily deployed to pr May 2, 2025 11:55 — with GitHub Actions Inactive

ThomasDevoogdt temporarily deployed to pr May 2, 2025 12:19 — with GitHub Actions Inactive

ThomasDevoogdt temporarily deployed to pr May 2, 2025 12:20 — with GitHub Actions Inactive

This was referenced May 5, 2025

build: only compile simdutf if there is CXX support #10277

Merged

Fluent Bit v4.0.1 in Buildroot?? - Need support! #10190

Closed

ThomasDevoogdt force-pushed the bugfix/sqlite3-disabled branch from 7092bc1 to 24532cd Compare May 7, 2025 07:28

ThomasDevoogdt temporarily deployed to pr May 7, 2025 07:28 — with GitHub Actions Inactive

patrick-stephens previously approved these changes Dec 22, 2025

View reviewed changes

ThomasDevoogdt added 4 commits April 21, 2026 12:00

in_blob: fix compilation if FLB_SQLDB (sqlite3) is disabled

54502e8

Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>

filter_checklist: fix compilation if FLB_SQLDB (sqlite3) is disabled

273e7e0

Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>

out_azure_blob: fix compilation if FLB_SQLDB (sqlite3) is disabled

d136594

Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>

blob_db: fix missing methods if not FLB_HAVE_SQLDB

c40e584

Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>

ThomasDevoogdt added 3 commits April 21, 2026 12:07

tests: runtime: filter_checklist: fix flb_test_mode_partial if !FLB_H…

1c5521e

…AVE_SQLDB Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>

tests: runtime_shell: exclude in_tail_expect if not FLB_HAVE_SQLDB

8494344

Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>

workflows: build with FLB_SQLDB=On|Off

3dfcf76

Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>

Uh oh!

Conversation

ThomasDevoogdt commented Apr 22, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

patrick-stephens commented Apr 24, 2025

Uh oh!

ThomasDevoogdt commented Apr 24, 2025

Uh oh!

ThomasDevoogdt commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

patrick-stephens commented May 2, 2025

Uh oh!

ThomasDevoogdt commented May 2, 2025

Uh oh!

patrick-stephens commented Nov 21, 2025

Uh oh!

leonardo-albertovich commented Nov 21, 2025

Uh oh!

ThomasDevoogdt commented Nov 21, 2025

Uh oh!

ThomasDevoogdt commented Nov 25, 2025

Uh oh!

leonardo-albertovich commented Nov 26, 2025

Uh oh!

ThomasDevoogdt commented Dec 5, 2025

Uh oh!

ThomasDevoogdt commented Dec 22, 2025

Uh oh!

ThomasDevoogdt commented Dec 22, 2025

Uh oh!

ThomasDevoogdt commented Jan 5, 2026

Uh oh!

ThomasDevoogdt commented Jan 14, 2026

Uh oh!

ThomasDevoogdt commented Jan 19, 2026

Uh oh!

ThomasDevoogdt commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

patrick-stephens commented Jan 28, 2026

Uh oh!

leonardo-albertovich commented Feb 4, 2026

Uh oh!

ThomasDevoogdt commented Feb 15, 2026

Uh oh!

ThomasDevoogdt commented Mar 5, 2026

Uh oh!

ThomasDevoogdt commented Mar 25, 2026

Uh oh!

ThomasDevoogdt commented Apr 21, 2026

Uh oh!

ThomasDevoogdt commented Apr 30, 2026

Uh oh!

ThomasDevoogdt commented May 28, 2026

Uh oh!

patrick-stephens commented Jun 2, 2026

Uh oh!

ThomasDevoogdt commented Jun 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ThomasDevoogdt commented Apr 22, 2025 •

edited by coderabbitai Bot

Loading

ThomasDevoogdt commented May 2, 2025 •

edited

Loading

ThomasDevoogdt commented Jan 27, 2026 •

edited

Loading