Add json.escape_unicode option to service configuration#2131
Conversation
owanio1992
force-pushed
the
fix/missing_doc_#10665
branch
from
50b5c77 to
35afdc1
Compare
owanio1992
changed the title
cosmo0920
left a comment
cosmo0920
left a comment
There was a problem hiding this comment.
json.escape_unicode handles boolean value. So,we need to use with On/true or Off/false for specifying escaping non-ASCII characters with Unicode code points.
|
@owanio1992 Could you add Signed-off line in your commit? Under the fluent organization repos, we request to use commit signs for every contributors. |
owanio1992
force-pushed
the
fix/missing_doc_#10665
branch
2 times, most recently
from
7327cc7 to
99100bd
Compare
|
I'll come back for a tech writing review once @cosmo0920 's requested changes are done =) |
cosmo0920
left a comment
cosmo0920
left a comment
There was a problem hiding this comment.
For technical perspective, it looks good.
But DCO still complains that the author and the commiter information differs like:
Commit sha: 99100bd, Author: owan, Committer: owan; Expected "owan chihhao.wang@zyxel.com.tw", but got "owanio1992 owan.io1992@gmail.com".
eschabell
added
waiting-for-user
|
@owanio1992 if you can look at the DCO failures this can be reviewed by @esmerel. |
owanio1992
force-pushed
the
fix/missing_doc_#10665
branch
2 times, most recently
from
b745e02 to
2a4e588
Compare
owanio1992
force-pushed
the
fix/missing_doc_#10665
branch
5 times, most recently
from
2e06f6b to
9daaeb3
Compare
Signed-off-by: owanio1992 <owan.io1992@gmail.com>
owanio1992
force-pushed
the
fix/missing_doc_#10665
branch
from
9daaeb3 to
9c63970
Compare
|
@cosmo0920 I update description and default value, please review again |
esmerel
left a comment
esmerel
left a comment
There was a problem hiding this comment.
3 comments, same question on each. otherwise this looks fine to me
cosmo0920
left a comment
cosmo0920
left a comment
There was a problem hiding this comment.
For technical side, it looks good to me. Thank you for your contribution.
Co-authored-by: Lynette Miles <6818907+esmerel@users.noreply.github.com> Signed-off-by: owan <owan.io1992@gmail.com>
…on-file.md Co-authored-by: Lynette Miles <6818907+esmerel@users.noreply.github.com> Signed-off-by: owan <owan.io1992@gmail.com>
Co-authored-by: Lynette Miles <6818907+esmerel@users.noreply.github.com> Signed-off-by: owan <owan.io1992@gmail.com>
eschabell
removed
waiting-for-user
|
Fixes #2132. |
5 participants
feature source PR: fluent/fluent-bit#10665
This commit adds the
json.escape_unicodeoption to the service configuration for both classic and YAML modes.This option allows users to control the encoding of raw UTF-8 strings when serializing MessagePack records to JSON.