out_s3: Add a description for pure C parquet#2111
Conversation
6e4b47e to
b659055
Compare
|
@esmerel Good morning. |
|
@esmerel review needed, see questions above. |
Signed-off-by: Lynette Miles <lynette.miles@chronosphere.io>
We add it to the spelling exceptions file for Vale. I went ahead and did that in #2116 =) And also the heading file, which I should have realized. #2117 |
esmerel
left a comment
There was a problem hiding this comment.
one suggestion that looks accidental
0b5a2a3 to
3b4b0d4
Compare
Signed-off-by: Lynette Miles <lynette.miles@chronosphere.io> Signed-off-by: Tom <yao.lin@siemens.com>
patrick-stephens
left a comment
There was a problem hiding this comment.
Looks fine other than adding the legacy format config as well.
- Apply suggestion from @esmerel Co-authored-by: Lynette Miles <6818907+esmerel@users.noreply.github.com> Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
3b4b0d4 to
0e3ab85
Compare
WalkthroughDocumentation updates for the S3 output: replaced a CloudWatch link with the official Amazon S3 guide, merged compression description into a “Compression/format” section clarifying build-time Arrow options, and added detailed Parquet prerequisites, build steps, examples, usage notes, plus a duplicated Parquet block and minor formatting tweak. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pipeline/outputs/s3.md(4 hunks)
🔇 Additional comments (3)
pipeline/outputs/s3.md (3)
700-723: LGTM on build requirements documentation.The Parquet build requirements section is clear and actionable, with a concrete Ubuntu/Debian example and proper references to external documentation for other distributions.
728-783: LGTM on testing configurations.The example configurations for Parquet testing are well-structured, providing both YAML and conf formats with appropriate settings for testing (debug logging, dummy input with diverse data types, and
use_put_objectenabled).
700-783: Verify: Has the legacy format request been addressed?A previous review comment from patrick-stephens requested: "We should add the legacy format as well." The current Parquet section doesn't explicitly mention legacy compression formats or other format options.
Please clarify:
- Does this PR need to document additional compression formats beyond
gzipandparquet?- If so, should they be added to this section or elsewhere in the documentation?
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pipeline/outputs/s3.md(4 hunks)
🔇 Additional comments (4)
pipeline/outputs/s3.md (4)
9-9: ✓ Helpful documentation link update.The change from the CloudWatch Logs S3 link to the official AWS S3 user guide is more appropriate and direct for users referencing S3 capabilities.
39-39: ✓ Comprehensive compression parameter documentation.The expanded
compressiondescription clearly distinguishes between:
- Always-available formats (gzip with
Content-Encodingheader behavior)- Build-time conditional formats (parquet requiring
-DFLB_ARROW=Onand Arrow GLib/Parquet GLib)- Typical usage patterns (Parquet with
use_put_object On)This is precise and helpful for users evaluating their build configuration.
700-722: ✓ Clear build requirements and instructions for Parquet support.The new "Build requirements for Parquet" section provides:
- Specific package installation steps for Ubuntu/Debian
- CMake command with the required
-DFLB_ARROW=Onflag- Reference to upstream Apache Parquet installation docs for other distributions
This guidance aligns well with the parameter documentation and enables users to set up Parquet correctly.
724-781: ✓ Thorough testing section with dual-format examples.The "Testing Parquet support" section includes:
- Complete service and pipeline configuration in both YAML and text (.conf) formats
- Realistic input (dummy input with mixed data types)
- Key Parquet-specific settings (
compression: parquet,use_put_object: On)- Comments noting where additional parameters can be added
Examples are clear and actionable.
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
|
code PR merged, so merging this doc update. |
Corresponding of fluent/fluent-bit#10691.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.