Added recognition of the client and recording his action.#2
Open
pekunicki wants to merge 1 commit intoflatplanetpl:masterfrom
Open
Added recognition of the client and recording his action.#2pekunicki wants to merge 1 commit intoflatplanetpl:masterfrom
pekunicki wants to merge 1 commit intoflatplanetpl:masterfrom
Conversation
pekunicki
changed the title
flatplanetpl
approved these changes
Apr 19, 2017
| public class PunsHub : Hub<IPunsClientHandler> | ||
| { | ||
| static List<string> Image =new List<string>(); | ||
| public static List<string> Images = new List<string>(); |
Owner
There was a problem hiding this comment.
Danger! Can be cross thread called. Use the thread safe collections.
| Clients.All.NumberOfUsers(Users.Size()); | ||
| Clients.All.Action(DateTime.Now.TimeOfDay,ActionType.Connecting.ToString(), id); | ||
| Clients.All.Users(Users.GetJson()); | ||
| } |
Owner
There was a problem hiding this comment.
This three calls Client.All can be aggregate in one.
| Users.ConnectedClients.Add(id,ip); | ||
| Clients.All.NumberOfUsers(Users.Size()); | ||
| Clients.All.Action(DateTime.Now.TimeOfDay,ActionType.Connecting.ToString(), id); | ||
| Clients.All.Users(Users.GetJson()); |
Owner
There was a problem hiding this comment.
You can just pass user collection. Let the signalR to serialize.
| textarea { | ||
| max-width: 280px; | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expanded our application by new features:
Paweł Kunicki