set_lsb_release: Fix running this against the SDK itself#3765
Merged
Conversation
I hadn't realised this is called for the SDK itself, i.e. without an applicable "board". I find having the SDK's os-release to be largely the same as the image's a little odd, but that's a different problem. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
tormath1
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set_lsb_release: Fix running this against the SDK itself
I hadn't realised this is called for the SDK itself, i.e. without an applicable "board". I find having the SDK's os-release to be largely the same as the image's a little odd, but that's a different problem.
How to use
Testing done
I've tried the above locally. The change is fairly trivial.
changelog/directory (user-facing change, bug fix, security fix, update) -- N/A/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.