Allow use of legacy OEM path while migrating modules to the new path#118
Open
chewi wants to merge 1 commit intoflatcar-masterfrom
Open
Allow use of legacy OEM path while migrating modules to the new path#118chewi wants to merge 1 commit intoflatcar-masterfrom
chewi wants to merge 1 commit intoflatcar-masterfrom
Conversation
The new minimal-init passed the contents of /oem to the second stage, but not the legacy /usr/share/oem path that is still documented. This change moves either the former or the latter into the second stage. This is no longer done via a bind mount, as that adds unnecessary complexity. At the same time, Dracut modules in the second stage can simply reference /oem rather than /usr/share/oem now that the first stage deals with the migration. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
Contributor
Author
|
CC @pothos |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow legacy OEM path while migrating to new path
The new minimal-init passed the contents of
/oemto the second stage, but not the legacy/usr/share/oempath that is still documented. This change moves either the former or the latter into the second stage. This is no longer done via a bind mount, as that adds unnecessary complexity.At the same time, Dracut modules in the second stage can simply reference
/oemrather than/usr/share/oemnow that the first stage deals with the migration.This addresses flatcar/Flatcar#2023.
How to use
Try the documented method. You can also try it with
/oeminstead of/usr/share/oem.Testing done
I've successfully done the above with both paths. I've also kicked off a Jenkins run.