Skip to content

[fix] import ai review workflow hardening#6

Merged
Andrey9kin merged 1 commit into
mainfrom
fix/import-ai-review-hardening
Jul 4, 2026
Merged

[fix] import ai review workflow hardening#6
Andrey9kin merged 1 commit into
mainfrom
fix/import-ai-review-hardening

Conversation

@Andrey9kin

Copy link
Copy Markdown
Member

Summary

  • fail BORIS setup when boris_mcp_url is configured
  • add BORIS output-use limits to the generated AGENTS.md block
  • restrict review comment body file reads to .ai-review-work
  • improve active comment matching, human-reply handling, thread pagination, and reply fallback behavior

Validation

  • git diff --check
  • embedded ai_review.py compile check

Import selected ai-code-review workflow hardening improvements.

- fail BORIS setup when boris_mcp_url is configured

- constrain BORIS output usage in the generated AGENTS.md block

- restrict comment body file reads to the review work directory

- improve active comment matching, human reply handling, thread pagination, and reply fallback behavior
@Andrey9kin
Andrey9kin force-pushed the fix/import-ai-review-hardening branch from 00f4c01 to 83d85f1 Compare July 4, 2026 11:52
@fivexl-reviewer

Copy link
Copy Markdown

AI Code Review Summary

  • Findings posted: 0 inline, 0 thread replies
  • Threads marked resolved: 0

Additional observations

  • bmcp init/sync/install/doctor commands (lines 899-900, 909, 920) no longer have fail-open error handling. Previously, failures were logged as warnings and the review continued. Now, transient BORIS MCP server issues will fail the entire review step, making the workflow brittle to external service failures.

Note for AI coding agents: detailed findings are posted as inline review comments on the diff — read the unresolved review threads (e.g. gh api repos/<owner>/<repo>/pulls/<pr>/comments) before making changes; this summary is only an overview.

This summary was automatically generated by the AI code review workflow.

@Andrey9kin
Andrey9kin merged commit 655d156 into main Jul 4, 2026
1 check passed
@Andrey9kin
Andrey9kin deleted the fix/import-ai-review-hardening branch July 4, 2026 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant