feat(fcm): Added support for specifying the analytics label for notifications.#597
Merged
hiranya911 merged 7 commits intofirebase:masterfrom Aug 12, 2019
chemidy:analytics_label
Merged
feat(fcm): Added support for specifying the analytics label for notifications.#597hiranya911 merged 7 commits intofirebase:masterfrom chemidy:analytics_label
hiranya911 merged 7 commits intofirebase:masterfrom
chemidy:analytics_label
Conversation
added 2 commits
July 20, 2019 12:37
hiranya911
suggested changes
Jul 22, 2019
hiranya911
reviewed
Jul 22, 2019
egilmorez
reviewed
Jul 22, 2019
egilmorez
reviewed
Jul 22, 2019
egilmorez
reviewed
Jul 22, 2019
egilmorez
reviewed
Jul 22, 2019
egilmorez
reviewed
Jul 22, 2019
egilmorez
reviewed
Jul 22, 2019
egilmorez
reviewed
Jul 22, 2019
egilmorez
reviewed
Jul 22, 2019
egilmorez
reviewed
Jul 22, 2019
egilmorez
reviewed
Jul 22, 2019
egilmorez
reviewed
Jul 22, 2019
Contributor
egilmorez
left a comment
egilmorez
left a comment
There was a problem hiding this comment.
Left some style comments. Thanks for the PR!
egilmorez
approved these changes
Jul 25, 2019
Contributor
egilmorez
left a comment
egilmorez
left a comment
There was a problem hiding this comment.
index.d.ts content looks good, thanks chemidy!
hiranya911
suggested changes
Jul 25, 2019
Contributor
hiranya911
left a comment
hiranya911
left a comment
There was a problem hiding this comment.
Looks good. Just need some test cases for the new validators.
And I'm also waiting to hear from the FCM team about fcmOptions vs fcm_options in the JSON payload.
hiranya911
changed the title
This was referenced Nov 13, 2019
This was referenced Mar 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FR:analytics_label support in FCM #580