Upgraded Firestore version to 0.16.0#322
Merged
hiranya911 merged 3 commits intomasterfrom Aug 3, 2018
Merged
Conversation
schmidt-sebastian
suggested changes
Aug 3, 2018
Contributor
schmidt-sebastian
left a comment
schmidt-sebastian
left a comment
There was a problem hiding this comment.
This is going to be my first "Request Changes" on these versioning PRs.
You should split out the Node 4 config change and create a single PR that does just that, along with a clear description of its intent.
Contributor
Author
|
Node4 related stuff have been sync'ed via #328 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also dropping Node4 config from CI, as Firestore (and GCP) no longer supports it.