Merged
Conversation
Contributor
hiranya911
commented
Jul 18, 2018
hiranya911
commented
- Re-exporting the Firestore Timestamp type
- Updating affected tests
schmidt-sebastian
approved these changes
Jul 20, 2018
Contributor
schmidt-sebastian
left a comment
schmidt-sebastian
left a comment
There was a problem hiding this comment.
LGTM.
There's a lot of churn in the package-lock.json though, when only one version should have changed.
test/integration/firestore.spec.ts
Outdated
| const data = snapshot.data(); | ||
| expect(data.timestamp).is.not.null; | ||
| expect(data.timestamp instanceof Date).is.true; | ||
| expect(data.timestamp instanceof admin.firestore.Timestamp).is.true; |
Contributor
There was a problem hiding this comment.
This is: expect(data.timestamp).to.be.instanceOf(admin.firestore.Timestamp)
Contributor
Author
There was a problem hiding this comment.
Done.
I believe the package-lock.json changes are because we define a lot of our dependencies loosely with wildcards. So everytime we regen the file, there are new versions to pick up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.