Skip to content

WIP feat(fcm): Add Support for AndroidConfigV2#771

Draft
jonathanedey wants to merge 2 commits into
devfrom
je-fcm-v2
Draft

WIP feat(fcm): Add Support for AndroidConfigV2#771
jonathanedey wants to merge 2 commits into
devfrom
je-fcm-v2

Conversation

@jonathanedey

Copy link
Copy Markdown
Contributor

This change implements support for the Android v2 API and It deprecates v1 AndroidConfig structures and replaces them with the new AndroidConfigV2 structures.

  • Adds AndroidConfigV2, AndroidNotificationV2, AndroidRemoteNotification, and AndroidBackgroundSyncMessage types.
  • Deprecates AndroidConfig, AndroidNotification, and AndroidNotificationProxy

@jonathanedey jonathanedey marked this pull request as draft July 9, 2026 19:33
@jonathanedey jonathanedey changed the title feat(fcm): Add Support for AndroidConfigV2 WIP feat(fcm): Add Support for AndroidConfigV2 Jul 9, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the V2 Android messaging configuration (AndroidConfigV2 and AndroidNotificationV2) to the messaging package, deprecating the older V1 Android configuration types. It includes JSON marshalling/unmarshalling implementations, validation logic, unit tests, and usage snippets. Feedback on the changes suggests resetting the VibrateTimingMillis slice in AndroidNotificationV2.UnmarshalJSON before appending to prevent duplicate values when the receiver struct is reused.

Comment thread messaging/messaging.go Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant