Skip to content

fix(auth): Fixed auth error code parsing#712

Merged
jonathanedey merged 3 commits into
devfrom
je-fix-auth-errors
Sep 10, 2025
Merged

fix(auth): Fixed auth error code parsing#712
jonathanedey merged 3 commits into
devfrom
je-fix-auth-errors

Conversation

@jonathanedey

Copy link
Copy Markdown
Contributor

The auth error code parser incorrectly mapped known error codes to unknown errors due to additional whitespace from the expected auth error message. This whitespace is now trimmed and correctly mapped to the corresponding auth error code.

@jonathanedey jonathanedey added the release:stage Stage a release candidate label Aug 26, 2025
@jonathanedey jonathanedey changed the base branch from master to dev August 26, 2025 14:49

@lahirumaramba lahirumaramba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonathanedey jonathanedey merged commit bac58d8 into dev Sep 10, 2025
8 checks passed
@jonathanedey jonathanedey deleted the je-fix-auth-errors branch September 10, 2025 15:14
@github-actions github-actions Bot mentioned this pull request Jan 21, 2026
lahirumaramba added a commit that referenced this pull request Jan 21, 2026
* chore: Added and `AGENTS.md` file to instruct AI agents how to interact with this repository (#710)

* fix(auth): Fixed auth error code parsing (#712)

* fix(auth): Fixed auth error code parsing

* fix(auth): Fixed test to use error message prefix

* chore: update copyright headers from Google Inc. to Google LLC (#713)

* chore: Update github actions workflows and integration test resources (#740)

* chore: Pinned github actions to a full-length commit SHA

* chore: Update integration test resources

* chore: Added environment label to release action

* Trigger integration tests

* feat(firestore): Added Firestore Multi Database Support (#733)

* feat(firestore): Add Firestore Multi Database Support

* fix: Address gemini review

* fix: gemini review

* fix: Update name from API review

* fix: Address review comments

* chore: Fix CONTRIBUTING.md typo

Co-authored-by: Lahiru Maramba <llahiru@gmail.com>

---------

Co-authored-by: Lahiru Maramba <llahiru@gmail.com>

* feat(auth): Add `QueryUsers` API (#727)

This change implements the accounts:query functionality, providing a new QueryUsers method that allows searching for users with filters and sorting options.

RELEASE_NOTE: Added QueryUsers() API to support querying user accounts with filters, sorting, and pagination.

* Update the release actions process (#741)

This PR refactors the release automation to improve security by removing the direct merge from the workflow.

* [chore] Release 4.19.0 (#742)

* Revert "[chore] Release 4.19.0 (#742)" (#744)

This reverts commit 3a86709.

* chore: Update Release Workflows for Push triggers (#745)

* chore: Update release actions to run on Release env

* Trigger CI

* update the actions

* update the base_ref

* remove fetch-depth to prevent conflicts

* [chore] Release 4.19.0 Take 2 (#746)

---------

Co-authored-by: Jonathan Edey <145066863+jonathanedey@users.noreply.github.com>
Co-authored-by: Lahiru Maramba <llahiru@gmail.com>
aminpaydar pushed a commit to aminpaydar/firebase-admin-go that referenced this pull request May 6, 2026
* chore: Added and `AGENTS.md` file to instruct AI agents how to interact with this repository (firebase#710)

* fix(auth): Fixed auth error code parsing (firebase#712)

* fix(auth): Fixed auth error code parsing

* fix(auth): Fixed test to use error message prefix

* chore: update copyright headers from Google Inc. to Google LLC (firebase#713)

* chore: Update github actions workflows and integration test resources (firebase#740)

* chore: Pinned github actions to a full-length commit SHA

* chore: Update integration test resources

* chore: Added environment label to release action

* Trigger integration tests

* feat(firestore): Added Firestore Multi Database Support (firebase#733)

* feat(firestore): Add Firestore Multi Database Support

* fix: Address gemini review

* fix: gemini review

* fix: Update name from API review

* fix: Address review comments

* chore: Fix CONTRIBUTING.md typo

Co-authored-by: Lahiru Maramba <llahiru@gmail.com>

---------

Co-authored-by: Lahiru Maramba <llahiru@gmail.com>

* feat(auth): Add `QueryUsers` API (firebase#727)

This change implements the accounts:query functionality, providing a new QueryUsers method that allows searching for users with filters and sorting options.

RELEASE_NOTE: Added QueryUsers() API to support querying user accounts with filters, sorting, and pagination.

* Update the release actions process (firebase#741)

This PR refactors the release automation to improve security by removing the direct merge from the workflow.

* [chore] Release 4.19.0 (firebase#742)

* Revert "[chore] Release 4.19.0 (firebase#742)" (firebase#744)

This reverts commit 3a86709.

* chore: Update Release Workflows for Push triggers (firebase#745)

* chore: Update release actions to run on Release env

* Trigger CI

* update the actions

* update the base_ref

* remove fetch-depth to prevent conflicts

* [chore] Release 4.19.0 Take 2 (firebase#746)

---------

Co-authored-by: Jonathan Edey <145066863+jonathanedey@users.noreply.github.com>
Co-authored-by: Lahiru Maramba <llahiru@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:stage Stage a release candidate release-note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants