Unifying callbacks setup with the observer machinery#427
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #427 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 1144 1174 +30
Branches 164 166 +2
=========================================
+ Hits 1144 1174 +30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fgmacedo
force-pushed
the
macedo/improve-callable-setup
branch
from
April 29, 2024 00:38
8c4b64e to
0298ad3
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Got faster setup by a factor of ~1.8x, and a much simpler callback machinery.
Changes
._setup()extra call;Complements the work done on #425.
TODO:
deepcopywith observers added to the state machine.