chore(deps): bump vite-plus to 0.1.21-alpha.7#10
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the versions of vite, vite-plus, and vitest to 0.1.21-alpha.7 and introduces a pnpm-workspace.yaml file. Feedback indicates that the minimumReleaseAgeExclude configuration is misplaced and should be moved to .npmrc, and that the new workspace file is missing the catalogs key and a packages definition.
| minimumReleaseAgeExclude: | ||
| - vite-plus | ||
| - "@voidzero-dev/*" |
There was a problem hiding this comment.
The minimumReleaseAgeExclude key is not a standard top-level property for pnpm-workspace.yaml. For pnpm, this configuration (as minimum-release-age-exclude) should be placed in .npmrc. For Bun, it belongs in bunfig.toml. Additionally, pnpm's implementation typically requires exact package names and does not support globs like "@voidzero-dev/*". If this is intended to bypass security checks for these alpha releases, it will likely be ignored by the package managers in this file.
| minimumReleaseAgeExclude: | ||
| - vite-plus | ||
| - "@voidzero-dev/*" |
There was a problem hiding this comment.
The PR summary mentions updating "catalogs" in pnpm-workspace.yaml, but the file is missing the catalogs key. Furthermore, adding this file turns the repository into a pnpm workspace; for a single-package project, it is recommended to explicitly define the workspace root (e.g., packages: ['.']) and define any catalogs here if you intend to use the catalog: protocol in package.json.
Summary
Bump
vite-plusand related packages to alpha 0.1.21-alpha.7.Updated where applicable:
vite-plusvitest(alias to@voidzero-dev/vite-plus-test)vite(alias to@voidzero-dev/vite-plus-core)overrides/resolutions/pnpm.overrides/pnpm-workspace.yamlcatalogsminimumReleaseAgeExclude/minimumReleaseAgeExcludesconfigured for pnpm + bunTest plan