Bump golang version, add io.StringWriter and improve performance#33
Open
boekkooi-impossiblecloud wants to merge 8 commits into
Open
Bump golang version, add io.StringWriter and improve performance#33boekkooi-impossiblecloud wants to merge 8 commits into
boekkooi-impossiblecloud wants to merge 8 commits into
Conversation
The interface was added to the io package in go 1.12. Related to: - https://go.dev/doc/go1.12#iopkgio - golang/go@33d531d
Following the same policy as golang. See https://go.dev/doc/devel/release#policy
This removes allocation for each Write call
A type is now created for each possible interface combination. Allowing Wrap to so a single allocation.
Owner
|
Thanks this looks great. I only found one issue. If you apply this change to your PR I'll go ahead and merge: boekkooi-impossiblecloud#1 |
Author
|
Hey @felixge, Thanks a lot for the review! Your against this one is merged 😄 Please let me know if anything else is needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day,
Thanks for reviewing this PR and sorry for the size of it but I wanted to share (and maybe have a chat about it).
The first thing this PR is doing is adding support for
io.StringWriterwhich was introduced in golang 1.12.It also bumps the supported golang version to 1.25 and up same as the currently supported golang versions.
Finally I started doing some performance improvements by:
This is a change in behavior and could require a v2 version of the library.
Again sorry for the size and thanks for having a look.
I hope some of this maybe useful 😄
Have a great day!