-
Notifications
You must be signed in to change notification settings - Fork 71
[CDTOOL-1259] Move the logging command under service
#1642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
logging command under service
kpfleming
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
All (or at least most) of the
describeandlistcommands support JSON output, so they will need the deprecation message suppressed. -
We should check with the Bulleit team to confirm that all of these logging endpoints are still available; the last time I checked at least one (maybe Loggly or Logshuttle) was out of business. This would be a good time to remove commands for logging services that can no longer be used.
|
Pending feedback from the logging team. |
kpfleming
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! We should wait a bit to see if we get feedback about removing any of the logging endpoints, but if we don't then this is ready to merge.
|
We have confirmation that none of these logging commands are deprecated. I'll be merging this PR now. |
Change summary
This PR moves the
loggingcommand under theservicecommand. A alias forfastly logging Xhas been added here to prevent breaking changes.All Submissions:
New Feature Submissions:
Changes to Core Features:
User Impact
None, alias' have been added to prevent breaking changes.