fix(ci): refresh the stale ghcommon script pin across reusable workflows#333
Merged
Conversation
Every reusable workflow that checks out this repo's own workflow scripts fell back to a hardcoded SHA when the calling repo had no .github/ghcommon-ref.txt. That SHA - e04c222 - is from 2026-03-28. Callers use the workflows at @main, so main's workflow logic was calling helper subcommands that the four-month-old pinned script does not define. Rust CI failed outright in every repo without the ref file: ##[error]Unknown command: rust-build The rust-* subcommands were added in 767acd4 on 2026-05-27, two months after the pinned commit. Surfaced by falkcorp/cockroach-rollout-agent, whose Rust CI activated for the first time during the TODO fan-out. Updates all 11 occurrences across 6 workflows to current main, and adds a comment on the primary fallback noting it must stay in step with the workflows shipped beside it. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013vU67T2LJDCbYTBs9ZFAf2
jdfalk
added a commit
to falkcorp/cockroach-rollout-agent
that referenced
this pull request
Jul 20, 2026
Picks up falkcorp/github-common#333 (stale ghcommon script pin), which restores the rust-build subcommand the Rust CI job invokes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013vU67T2LJDCbYTBs9ZFAf2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every reusable workflow that checks out this repo's own
.github/workflows/scriptsfalls back to a hardcoded SHA when the calling repohas no
.github/ghcommon-ref.txt:That commit is from 2026-03-28. Callers consume the workflows at
@main, somain's workflow logic has been invoking helper subcommands that the four-month-old pinned script doesn't define:
The
rust-*subcommands were added in767acd4on 2026-05-27 — two monthsafter the pin. So Rust CI fails outright in every repo without the ref file.
Surfaced by
falkcorp/cockroach-rollout-agent, whose Rust CI activated for thefirst time during the TODO fan-out (its
Cargo.lockchanged). Verified locallythat the repo itself is fine —
cargo clippy --all-targets -- -D warnings,cargo build --releaseandcargo testall pass; the failure was purely thisversion skew.
Change
All 11 occurrences across 6 workflows now point at current
main:reusable-ci.ymlreusable-release.ymlreusable-advanced-cache.ymlreusable-maintenance.ymlreusable-security.ymlcommit-override-handler.ymlThe primary fallback now carries a comment explaining that it must be kept in
step with the workflows shipped beside it — a stale pin here means
maincalls into scripts that predate it.
Testing
actionlintclean on all six changed workflows — no structural errors, and theonly output is pre-existing shellcheck warnings in untouched
run:blocks.🤖 Generated with Claude Code
https://claude.ai/code/session_013vU67T2LJDCbYTBs9ZFAf2