fix(todo): format the assembler so it is stable at any ruff line-length#331
Merged
Conversation
ruff format is not idempotent across line-lengths - a file formatted at 80 columns has its short lines rejoined at 88. assemble_todo.py is copied verbatim into repos with no ruff.toml of their own, where ruff falls back to its 88-column default, so `ruff format --check` failed there on a file that is correctly formatted here. Surfaced by the fan-out: falkcorp/cockroach-rollout-agent has no ruff config, and its Python CI rejected the file. Every multi-line construct now carries a magic trailing comma, which pins it exploded regardless of width. The two that could not take one - a bare generator argument and an implicitly concatenated string - were reshaped to fit under 79 columns instead. Output verified byte-identical at widths 79, 80, 88, 100, 120 and 200, and the file passes ruff check and ruff format --check under both this repo's config and a bare --isolated default. Round-trip behavior is unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013vU67T2LJDCbYTBs9ZFAf2
jdfalk
added a commit
to falkcorp/transcoderr
that referenced
this pull request
Jul 20, 2026
Picks up falkcorp/github-common#331: ruff format is not idempotent across line-lengths, so the previous copy failed `ruff format --check` in repos that have no ruff.toml and fall back to ruff's 88-column default. Output is now byte-identical at any width. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013vU67T2LJDCbYTBs9ZFAf2
jdfalk
added a commit
to falkcorp/audiobook-organizer
that referenced
this pull request
Jul 20, 2026
Picks up falkcorp/github-common#331: ruff format is not idempotent across line-lengths, so the previous copy failed `ruff format --check` in repos that have no ruff.toml and fall back to ruff's 88-column default. Output is now byte-identical at any width. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013vU67T2LJDCbYTBs9ZFAf2
jdfalk
added a commit
to falkcorp/subtitle-manager
that referenced
this pull request
Jul 20, 2026
Picks up falkcorp/github-common#331: ruff format is not idempotent across line-lengths, so the previous copy failed `ruff format --check` in repos that have no ruff.toml and fall back to ruff's 88-column default. Output is now byte-identical at any width. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013vU67T2LJDCbYTBs9ZFAf2
jdfalk
added a commit
to falkcorp/ubuntu-autoinstall-agent
that referenced
this pull request
Jul 20, 2026
Picks up falkcorp/github-common#331: ruff format is not idempotent across line-lengths, so the previous copy failed `ruff format --check` in repos that have no ruff.toml and fall back to ruff's 88-column default. Output is now byte-identical at any width. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013vU67T2LJDCbYTBs9ZFAf2
jdfalk
added a commit
to falkcorp/ubuntu-autoinstall-webhook
that referenced
this pull request
Jul 20, 2026
Picks up falkcorp/github-common#331: ruff format is not idempotent across line-lengths, so the previous copy failed `ruff format --check` in repos that have no ruff.toml and fall back to ruff's 88-column default. Output is now byte-identical at any width. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013vU67T2LJDCbYTBs9ZFAf2
jdfalk
added a commit
to falkcorp/gcommon-go
that referenced
this pull request
Jul 20, 2026
Picks up falkcorp/github-common#331: ruff format is not idempotent across line-lengths, so the previous copy failed `ruff format --check` in repos that have no ruff.toml and fall back to ruff's 88-column default. Output is now byte-identical at any width. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013vU67T2LJDCbYTBs9ZFAf2
jdfalk
added a commit
to falkcorp/emergency-console
that referenced
this pull request
Jul 20, 2026
Picks up falkcorp/github-common#331: ruff format is not idempotent across line-lengths, so the previous copy failed `ruff format --check` in repos that have no ruff.toml and fall back to ruff's 88-column default. Output is now byte-identical at any width. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013vU67T2LJDCbYTBs9ZFAf2
jdfalk
added a commit
to falkcorp/mtls-bridge
that referenced
this pull request
Jul 20, 2026
Picks up falkcorp/github-common#331: ruff format is not idempotent across line-lengths, so the previous copy failed `ruff format --check` in repos that have no ruff.toml and fall back to ruff's 88-column default. Output is now byte-identical at any width. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013vU67T2LJDCbYTBs9ZFAf2
jdfalk
added a commit
to falkcorp/migrate-loop
that referenced
this pull request
Jul 20, 2026
Picks up falkcorp/github-common#331: ruff format is not idempotent across line-lengths, so the previous copy failed `ruff format --check` in repos that have no ruff.toml and fall back to ruff's 88-column default. Output is now byte-identical at any width. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013vU67T2LJDCbYTBs9ZFAf2
jdfalk
added a commit
to falkcorp/overnight-burndown
that referenced
this pull request
Jul 20, 2026
Picks up falkcorp/github-common#331: ruff format is not idempotent across line-lengths, so the previous copy failed `ruff format --check` in repos that have no ruff.toml and fall back to ruff's 88-column default. Output is now byte-identical at any width. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013vU67T2LJDCbYTBs9ZFAf2
jdfalk
added a commit
to falkcorp/cockroach-rollout-agent
that referenced
this pull request
Jul 20, 2026
Picks up falkcorp/github-common#331: ruff format is not idempotent across line-lengths, so the previous copy failed `ruff format --check` in repos that have no ruff.toml and fall back to ruff's 88-column default. Output is now byte-identical at any width. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013vU67T2LJDCbYTBs9ZFAf2
jdfalk
added a commit
to falkcorp/safe-ai-util
that referenced
this pull request
Jul 20, 2026
Picks up falkcorp/github-common#331: ruff format is not idempotent across line-lengths, so the previous copy failed `ruff format --check` in repos that have no ruff.toml and fall back to ruff's 88-column default. Output is now byte-identical at any width. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013vU67T2LJDCbYTBs9ZFAf2
jdfalk
added a commit
to falkcorp/magnet-handler
that referenced
this pull request
Jul 20, 2026
Picks up falkcorp/github-common#331: ruff format is not idempotent across line-lengths, so the previous copy failed `ruff format --check` in repos that have no ruff.toml and fall back to ruff's 88-column default. Output is now byte-identical at any width. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013vU67T2LJDCbYTBs9ZFAf2
jdfalk
added a commit
to falkcorp/transcoderr
that referenced
this pull request
Jul 21, 2026
Picks up falkcorp/github-common#331: ruff format is not idempotent across line-lengths, so the previous copy failed `ruff format --check` in repos that have no ruff.toml and fall back to ruff's 88-column default. Output is now byte-identical at any width. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013vU67T2LJDCbYTBs9ZFAf2
jdfalk
added a commit
to falkcorp/audiobook-organizer
that referenced
this pull request
Jul 21, 2026
Picks up falkcorp/github-common#331: ruff format is not idempotent across line-lengths, so the previous copy failed `ruff format --check` in repos that have no ruff.toml and fall back to ruff's 88-column default. Output is now byte-identical at any width. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013vU67T2LJDCbYTBs9ZFAf2
jdfalk
added a commit
to falkcorp/ubuntu-autoinstall-agent
that referenced
this pull request
Jul 21, 2026
Picks up falkcorp/github-common#331: ruff format is not idempotent across line-lengths, so the previous copy failed `ruff format --check` in repos that have no ruff.toml and fall back to ruff's 88-column default. Output is now byte-identical at any width. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013vU67T2LJDCbYTBs9ZFAf2
jdfalk
added a commit
to falkcorp/gcommon-go
that referenced
this pull request
Jul 21, 2026
Picks up falkcorp/github-common#331: ruff format is not idempotent across line-lengths, so the previous copy failed `ruff format --check` in repos that have no ruff.toml and fall back to ruff's 88-column default. Output is now byte-identical at any width. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013vU67T2LJDCbYTBs9ZFAf2
jdfalk
added a commit
to falkcorp/emergency-console
that referenced
this pull request
Jul 21, 2026
Picks up falkcorp/github-common#331: ruff format is not idempotent across line-lengths, so the previous copy failed `ruff format --check` in repos that have no ruff.toml and fall back to ruff's 88-column default. Output is now byte-identical at any width. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013vU67T2LJDCbYTBs9ZFAf2
jdfalk
added a commit
to falkcorp/mtls-bridge
that referenced
this pull request
Jul 21, 2026
Picks up falkcorp/github-common#331: ruff format is not idempotent across line-lengths, so the previous copy failed `ruff format --check` in repos that have no ruff.toml and fall back to ruff's 88-column default. Output is now byte-identical at any width. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013vU67T2LJDCbYTBs9ZFAf2
jdfalk
added a commit
to falkcorp/migrate-loop
that referenced
this pull request
Jul 21, 2026
Picks up falkcorp/github-common#331: ruff format is not idempotent across line-lengths, so the previous copy failed `ruff format --check` in repos that have no ruff.toml and fall back to ruff's 88-column default. Output is now byte-identical at any width. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013vU67T2LJDCbYTBs9ZFAf2
jdfalk
added a commit
to falkcorp/overnight-burndown
that referenced
this pull request
Jul 21, 2026
Picks up falkcorp/github-common#331: ruff format is not idempotent across line-lengths, so the previous copy failed `ruff format --check` in repos that have no ruff.toml and fall back to ruff's 88-column default. Output is now byte-identical at any width. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013vU67T2LJDCbYTBs9ZFAf2
jdfalk
added a commit
to falkcorp/magnet-handler
that referenced
this pull request
Jul 21, 2026
Picks up falkcorp/github-common#331: ruff format is not idempotent across line-lengths, so the previous copy failed `ruff format --check` in repos that have no ruff.toml and fall back to ruff's 88-column default. Output is now byte-identical at any width. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013vU67T2LJDCbYTBs9ZFAf2
jdfalk
added a commit
to falkcorp/safe-ai-util
that referenced
this pull request
Jul 21, 2026
Picks up falkcorp/github-common#331: ruff format is not idempotent across line-lengths, so the previous copy failed `ruff format --check` in repos that have no ruff.toml and fall back to ruff's 88-column default. Output is now byte-identical at any width. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013vU67T2LJDCbYTBs9ZFAf2
jdfalk
added a commit
to falkcorp/subtitle-manager
that referenced
this pull request
Jul 21, 2026
Picks up falkcorp/github-common#331: ruff format is not idempotent across line-lengths, so the previous copy failed `ruff format --check` in repos that have no ruff.toml and fall back to ruff's 88-column default. Output is now byte-identical at any width. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013vU67T2LJDCbYTBs9ZFAf2
jdfalk
added a commit
to falkcorp/cockroach-rollout-agent
that referenced
this pull request
Jul 21, 2026
Picks up falkcorp/github-common#331: ruff format is not idempotent across line-lengths, so the previous copy failed `ruff format --check` in repos that have no ruff.toml and fall back to ruff's 88-column default. Output is now byte-identical at any width. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013vU67T2LJDCbYTBs9ZFAf2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ruff formatis not idempotent across line-lengths — a file formatted at 80columns has its short lines rejoined at 88.
scripts/assemble_todo.pyis copiedverbatim into repos that have no
ruff.tomlof their own, where ruff falls backto its 88-column default, so
ruff format --checkrejected a file that iscorrectly formatted here.
Surfaced by the TODO fan-out:
falkcorp/cockroach-rollout-agenthas no ruffconfig, and its Python CI failed on the copied file.
Fix
Every multi-line construct now carries a magic trailing comma, which pins it
exploded regardless of width. The two that could not take one — a bare generator
argument to
sorted()and an implicitly concatenated string — were reshaped tofit under 79 columns instead.
Testing
ruff checkandruff format --checkunder both this repo's config anda bare
--isolateddefault (the fan-out repos' situation).deleted.
🤖 Generated with Claude Code
https://claude.ai/code/session_013vU67T2LJDCbYTBs9ZFAf2