Move and revise terminology section - #57
Open
maximiliani wants to merge 7 commits into
Open
Conversation
… fixing definitions
Move and revise terminology section
🚀 PR Preview AvailableA preview deployment of this PR is now available. 🔗 Preview URL: https://fairdo-org.github.io/fdo-architecture-spec/preview/pr-57/ |
jboehm1911
reviewed
Jul 30, 2026
| </dd> | ||
|
|
||
| <dt><h4 class="rule-heading" id="rule-r1_3">[R1-3] <dfn>Global <a>PID</a> Resolution</dfn></h4></dt> | ||
| <dt><h4 class="rule-heading" id="rule-r1_3">[R1-3] <dfn data-lt="pid resolution">Global <a>PID</a> Resolution</dfn></h4></dt> |
Contributor
There was a problem hiding this comment.
Use capital letters for pid.
Also add resolution as data-lt.
jboehm1911
reviewed
Jul 30, 2026
| It defines a set of <a>attribute definitions</a> that MUST be contained in any <a>FDO Record</a> | ||
| instantiating the profile, according to the cardinalities specified in the <a>attribute definitions</a> (see <a | ||
| href="#rule-r5_7">[R5-7]</a>). | ||
| instantiating the profile, according to the cardinalities specified in the <a>attribute definitions</a> (see <a href="#rule-r5_7"></a>). |
Contributor
There was a problem hiding this comment.
Use <a>profile</a>.
Use <a>cardinalities</a> and add a dfn for cardinality.
Contributor
|
The change needs to be discussed by the group, whether we need that section at all. The current list contains terms not used in the document. If we use the respec functions all used terms are links anyway to their definition. |
maximiliani
added
the
Future discussion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #50 and does the following:
Please check if I deleted too many terminology definitions.