Skip to content

[eslint-plugin] Support importSources object syntax in validImports#1039

Merged
necolas merged 1 commit into
mainfrom
gh-pr/569
May 2, 2025
Merged

[eslint-plugin] Support importSources object syntax in validImports#1039
necolas merged 1 commit into
mainfrom
gh-pr/569

Conversation

@necolas

@necolas necolas commented May 2, 2025

Copy link
Copy Markdown
Contributor

Rebase of #569

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 2, 2025
@github-actions

github-actions Bot commented May 2, 2025

Copy link
Copy Markdown

workflow: benchmarks/perf

Comparison of performance test results, measured in operations per second. Larger is better.

benchmarks@0.12.0 compare
node ./compare.js /tmp/tmp.3MwIDA1Srw /tmp/tmp.gkvN8cYmbS

Results Base Patch Ratio
babel-plugin: stylex.create
· basic create 541 536 0.99 -
· complex create 186 197 1.06 !!
babel-plugin: stylex.createTheme
· basic themes 460 457 0.99 -
· complex themes 42 42 1.00

@github-actions

github-actions Bot commented May 2, 2025

Copy link
Copy Markdown

workflow: benchmarks/size

Comparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.

benchmarks@0.12.0 compare
node ./compare.js /tmp/tmp.fHou949CXG /tmp/tmp.TTyvfduFci

Results Base Patch Ratio
stylex/lib/cjs/stylex.js
· compressed 1,172 1,172 1.00
· minified 3,395 3,395 1.00
stylex/lib/cjs/inject.js
· compressed 1,227 1,227 1.00
· minified 3,224 3,224 1.00
benchmarks/size/.build/bundle.js
· compressed 537,611 537,611 1.00
· minified 7,435,904 7,435,904 1.00
benchmarks/size/.build/stylex.css
· compressed 100,509 100,509 1.00
· minified 754,513 754,513 1.00

Comment thread packages/eslint-plugin/__tests__/stylex-sort-keys-test.js Outdated
@necolas necolas mentioned this pull request May 2, 2025
18 tasks
@necolas necolas merged commit 9cbe4a5 into main May 2, 2025
9 checks passed
@necolas necolas deleted the gh-pr/569 branch June 23, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants