Remove @nosideeffects from create-react-class#9928
Remove @nosideeffects from create-react-class#9928tupton wants to merge 1 commit intofacebook:15.5-devfrom
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Please send this against |
|
Closing in favor of #9933 (against the correct branch), thanks for raising awareness though. |
|
This should be fixed in |
Fixes the remaining issue with
@nosideeffectsand thecreate-react-classaddon, as mentioned in #7551 (context.)Before submitting a pull request, please make sure the following is done:
master.npm test).npm run lint).npm run prettier).npm run flow)../scripts/fiber/record-testsbefore submitting the pull request, and commit the resulting changes.