Disable tests of recovering from node.normalize()#9853
Merged
sebmarkbage merged 1 commit intofacebook:masterfrom Jun 5, 2017
Merged
Disable tests of recovering from node.normalize()#9853sebmarkbage merged 1 commit intofacebook:masterfrom
sebmarkbage merged 1 commit intofacebook:masterfrom
Conversation
bvaughn
approved these changes
Jun 5, 2017
Contributor
|
Should we keep these tests around if we are not supporting this in the near future? If/when this comes up again, we'll look at the issue, which would lead to looking at this PR, and we can pull the tests out of version control history then, right? Either way, thanks for doing this so quickly. |
According to facebook#9836 we're intentionally chosing to not support this until we have better proof of this being a big need. E.g. to protect against extensions. In a way that it's not better to push extensions to be fixed.
sebmarkbage
force-pushed
the
normalizedtext
branch
from
4c02622 to
903b49f
Compare
Contributor
Author
|
Ideally I'd want jest to warn if these tests start passing. E.g. because we add another change to how we're handling text nodes that might make it worth explicitly supporting this. |
This was referenced Jun 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to #9836 we're intentionally choosing to not support this until we have better proof of this being a big need. E.g. to protect against extensions. In a way that it's not better to push extensions to be fixed.
I went with the
xitmodel since jest doesn't yet have a way to intentionally fail. We already have precedent for otherxitin our tests.