Remove createClass, PropTypes, DOM factories, and createMixin from React object#9788
Merged
gaearon merged 1 commit intofacebook:masterfrom May 30, 2017
Merged
Remove createClass, PropTypes, DOM factories, and createMixin from React object#9788gaearon merged 1 commit intofacebook:masterfrom
gaearon merged 1 commit intofacebook:masterfrom
Conversation
gaearon
force-pushed
the
remove-cc
branch
2 times, most recently
from
d5188d2 to
a26fcbf
Compare
Contributor
|
I was just making an issue to track this, and then saw that you were already working on it. Nice. :) |
flarnie
approved these changes
May 27, 2017
Contributor
flarnie
left a comment
flarnie
left a comment
There was a problem hiding this comment.
I love the sound of code being deleted~
| "react.production.min.js (UMD_PROD)": { | ||
| "size": 15753, | ||
| "gzip": 5824 | ||
| "size": 7756, |
nhunzaker
approved these changes
May 29, 2017
Contributor
nhunzaker
left a comment
nhunzaker
left a comment
There was a problem hiding this comment.
Not really sure I can approve this, but it makes me happy!
Collaborator
Author
|
Internal callers in www should be patched up, and we'll need to codemod fbsource soon anyway. |
This was referenced Jun 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's still a few callers in www which I'll fix internally before merging.
We also have some RN code that still uses them but plan to either codemod it or shim it for the time being. In either case this will only matter after we cut another
reactpackage and update internal RN code to use it, which probably won't happen before codemodding.