Updated form docs to reflect functional set state#9734
Closed
jordanpapaleo wants to merge 1 commit intofacebook:masterfrom
jordanpapaleo:functional-setstate-forms
Closed
Updated form docs to reflect functional set state#9734jordanpapaleo wants to merge 1 commit intofacebook:masterfrom jordanpapaleo:functional-setstate-forms
jordanpapaleo wants to merge 1 commit intofacebook:masterfrom
jordanpapaleo:functional-setstate-forms
Conversation
jwbay
reviewed
May 22, 2017
| var partialState = {}; | ||
| partialState[name] = value; | ||
| this.setState(partialState); | ||
| this.setState(() => partialState); |
Contributor
There was a problem hiding this comment.
This is no longer ES5 code 😯
Author
|
That's how a lot of the examples are already. I just continued the process per the issue.
Sent from my smallest computer
On May 22, 2017, at 4:32 PM, jwbay <notifications@github.com> wrote:
@jwbay commented on this pull request.
In docs/docs/forms.md:
```
It is equivalent to this ES5 code:
```js{2}
var partialState = {};
partialState[name] = value;
-this.setState(partialState);
+this.setState(() => partialState);
This is no longer ES5 code 😯
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Author
|
Put in PR#9748 |
This was referenced Jun 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes#9703