Add 'unreleased' incremental change log for v15.6.0#9544
Merged
flarnie merged 3 commits intofacebook:masterfrom May 3, 2017
Merged
Add 'unreleased' incremental change log for v15.6.0#9544flarnie merged 3 commits intofacebook:masterfrom
flarnie merged 3 commits intofacebook:masterfrom
Conversation
gaearon
requested changes
Apr 27, 2017
CHANGELOG.md
Outdated
|
|
||
| ### React | ||
|
|
||
| * Fix bug where performance entries were being cleared. ([@chrisui](https://github.com/chrisui) in [9451](https://github.com/facebook/react/pull/9451)) |
Collaborator
There was a problem hiding this comment.
Styling nit: some PR links are missing hashes in text
Contributor
Author
There was a problem hiding this comment.
nice catch - will fix
CHANGELOG.md
Outdated
| ### React | ||
|
|
||
| * Fix bug where performance entries were being cleared. ([@chrisui](https://github.com/chrisui) in [9451](https://github.com/facebook/react/pull/9451)) | ||
| * Stop adding 'px' to numbers passed for CSS Grid attributes. ([@ericsakmar](https://github.com/ericsakmar) in [9185](https://github.com/facebook/react/pull/9185)) |
Collaborator
There was a problem hiding this comment.
Maybe "for unitless CSS Grid attributes"
CHANGELOG.md
Outdated
|
|
||
| * Fix bug where performance entries were being cleared. ([@chrisui](https://github.com/chrisui) in [9451](https://github.com/facebook/react/pull/9451)) | ||
| * Stop adding 'px' to numbers passed for CSS Grid attributes. ([@ericsakmar](https://github.com/ericsakmar) in [9185](https://github.com/facebook/react/pull/9185)) | ||
| * Deprecate `React.createMixin`. ([@aweary](https://github.com/aweary) in [#8853](https://github.com/facebook/react/pull/8853)) |
Collaborator
There was a problem hiding this comment.
Maybe add " which was never used". People might think this is deprecating the mixin system otherwise.
Contributor
Author
There was a problem hiding this comment.
Nice touch - will fix.
Collaborator
|
The details tag looks so sweet! |
**what is the change?:** Adding a section to the change log where we start accumulating annotations for React v15.6.0. **why make this change?:** - Saves us the trouble of writing the change log entry all at once when we do the release. - Adds transparency about what is in the upcoming release, for those who aren't following facebook#9398 **test plan:** Visual inspection **issue:** facebook#9398
**what is the change?:** - added missing `#` for commit hashes - added minor details to two annotations Thanks to @gaearon for the code review comments. **why make this change?:** Consistency and clarity. **test plan:** Visual inspection **issue:** facebook#9398
flarnie
force-pushed
the
add15-6-UnreleasedSectionToChangelog
branch
from
13758c5 to
31b64c2
Compare
gaearon
reviewed
May 1, 2017
CHANGELOG.md
Outdated
|
|
||
| ### React | ||
| * Fix erroneous PropTypes access warning. ([@acdlite](https://github.com/acdlite) in ([ec97ebb](https://github.com/facebook/react/commit/ec97ebbe7f15b58ae2f1323df39d06f119873344)) | ||
| * Fix erroneous PropTypes access warning. ([@acdlite](https://github.com/acdlite) in ([#ec97ebb](https://github.com/facebook/react/commit/ec97ebbe7f15b58ae2f1323df39d06f119873344)) |
Collaborator
There was a problem hiding this comment.
Sorry I wasn't being clear. We put # in for PR numbers, but don't include it for commits.
Collaborator
There was a problem hiding this comment.
(For PRs and commits, this is identical to how GH links work if you just paste a link. Unfortunately this doesn't work in Markdown documents, which is why we do this manually.)
Contributor
Author
There was a problem hiding this comment.
Gotcha - fixing now.
**what is the change?:** We had added hashes to some commit numbers, but ideally only do that for PRs. **why make this change?:** Consistency - this is how github displays those types of links too. PRs get a '#', and commits don't. **test plan:** Visual inspection **issue:** facebook#9398
Contributor
Contributor
Author
|
Thanks for the heads up @TrySound - I'll add that PR to the '15.6' changelog after I cherry-pick it. I actually tried yesterday, and got a bunch of failing tests on 15.6 as a result, so need to look into that. |
gaearon
approved these changes
May 3, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what is the change?:
Adding a section to the change log where we start accumulating
annotations for React v15.6.0.
why make this change?:
we do the release.
aren't following React 15.6 Umbrella #9398
test plan:
Visual inspection
issue:
#9398