Don't use key when defined on String, Number prototypes#5536
Merged
zpao merged 1 commit intofacebook:masterfrom Dec 1, 2015
Merged
Don't use key when defined on String, Number prototypes#5536zpao merged 1 commit intofacebook:masterfrom
key when defined on String, Number prototypes#5536zpao merged 1 commit intofacebook:masterfrom
Conversation
Member
Author
|
@spicyj do I get a prize for (attempting to) fix an old issue? Maybe not as old as yours but still… |
Collaborator
|
Sure, back at 'cha. 🎁 |
zpao
added a commit
that referenced
this pull request
Dec 1, 2015
Don't use `key` when defined on String, Number prototypes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hasOwnPropertymight be the real check we want here but thetypeofcheck fixed the case we cared about (basically just strings and numbers, everything else looks forkey)Fixes #2612