Only use latin1 characters in useId algorithm#33421
Closed
eps1lon wants to merge 1 commit intofacebook:mainfrom
Closed
Only use latin1 characters in useId algorithm#33421eps1lon wants to merge 1 commit intofacebook:mainfrom
useId algorithm#33421eps1lon wants to merge 1 commit intofacebook:mainfrom
Conversation
github-actions
bot
added
the
React Core Team
|
Comparing: 2b4064e...f48056c Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
Collaborator
Author
|
Closing in favor of #33422 |
sebmarkbage
added a commit
that referenced
this pull request
Jun 3, 2025
Alternative to #33421. The difference is that this also adds an underscore between the "R" and the ID. The reason we wanted to use special characters is because we use the full spectrum of A-Z 0-9 in our ID generation so we can basically collide with any common word (or anyone using a similar algorithm, base64 or even base16). It's a little less likely that someone would put `_R_` specifically unless you generate like two IDs separated by underscore. 
github-actions bot
pushed a commit
that referenced
this pull request
Jun 3, 2025
Alternative to #33421. The difference is that this also adds an underscore between the "R" and the ID. The reason we wanted to use special characters is because we use the full spectrum of A-Z 0-9 in our ID generation so we can basically collide with any common word (or anyone using a similar algorithm, base64 or even base16). It's a little less likely that someone would put `_R_` specifically unless you generate like two IDs separated by underscore.  DiffTrain build for [1ae0a84](1ae0a84)
github-actions bot
pushed a commit
that referenced
this pull request
Jun 3, 2025
Alternative to #33421. The difference is that this also adds an underscore between the "R" and the ID. The reason we wanted to use special characters is because we use the full spectrum of A-Z 0-9 in our ID generation so we can basically collide with any common word (or anyone using a similar algorithm, base64 or even base16). It's a little less likely that someone would put `_R_` specifically unless you generate like two IDs separated by underscore.  DiffTrain build for [1ae0a84](1ae0a84)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #33410
:as a delimiter produced invalid CSS selectors.«»are not valid XML 1.0 names._should be valid in all scenarios. The Root still has anidentifierPrefixoption if that causes conflicts.How did you test this change?
Search&replace for
«,»,\u00AB, and\u00BB