Fix flow configs creation for crlf systems#30707
Closed
alexdln wants to merge 1 commit intofacebook:mainfrom
Closed
Fix flow configs creation for crlf systems#30707alexdln wants to merge 1 commit intofacebook:mainfrom
alexdln wants to merge 1 commit intofacebook:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Comparing: a960b92cb93e7d006e5e8de850f9b8b51f655c90...87f2c9be64fc31a81b174cbf7a94e73aebd787a5 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
ab07265 to
7bf39f6
Compare
Member
|
I think we can remove this altogether: #30753 |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The error appears in CRLF systems because the end of the line is
\r\ninstead of just\n. In this case, the line in CRLF is%CI_MAX_WORKERS%\r\n, and therefore the condition%CI_MAX_WORKERS%\nfor this line isn't met.Rewrote the replace rule with a regular expression that allows an optional
\r(\r?) before\n.Fixes #27691