[DevTools] e2e Regression Testing App#24619
Merged
lunaruan merged 1 commit intofacebook:mainfrom May 26, 2022
Merged
Conversation
bvaughn
approved these changes
May 26, 2022
Contributor
bvaughn
left a comment
There was a problem hiding this comment.
Open Question @bvaughn: Can this replace the e2e folder, or is it worth it to keep the e2e folder around for now? I'm inclined to leave and delete later.
I don't have much of an opinion on this. Whatever you think is best.
I just skimmed this because I don't want to hold up your progress, but I don't have much extra brain power right now to context switch to this. If you want a more thorough review, maybe Mengdi can do it or I could do it in a day or two?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an e2e regression app to the
react-devtools-shellpackage. This app:app.jsand anappLegacy.jsentrypoint because apps prior to React 18 need to useReactDOM.render. These files will create and render multiple test apps (though they currently only render the List)ListAppout of thee2efolder and into ane2e-appsfolder so that bothe2eande2e-regressioncan use the same test appsListAppLegacyapp because prior to React 16.8 hooks didn't exist.devtoolsfile for thee2e-regressione2e-regressionReact app can use different a different React version than DevToolsOpen Question @bvaughn: Can this replace the
e2efolder, or is it worth it to keep thee2efolder around for now? I'm inclined to leave and delete later.