Add option for source maps when running tests#24577
Merged
acdlite merged 1 commit intofacebook:mainfrom May 18, 2022
Merged
Conversation
I added a `--sourceMaps` option to our test command that enables inline source maps. I've kept it disabled by default, since it makes the tests run slower. But it's super useful when attaching to a debugger.
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: a412d78...268bbe1 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
XYShaoKang
added a commit
to XYShaoKang/react
that referenced
this pull request
Feb 22, 2023
In facebook#24577, the `--sourceMaps` option was added, but modifying the `--sourceMaps` option has no effect. Because `process.env.JEST_ENABLE_SOURCE_MAPS` was not added to the string array of `createCacheKeyFunction`, it caused a cache to be generated when the first test was run, and when the second test was run, modifying `process.env.JEST_ENABLE_SOURCE_MAPS` would not affect the running result, resulting in the failure of the `--sourceMaps`.
This was referenced Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a
--sourceMapsoption to our test command that enables inline source maps. I've kept it disabled by default, since it makes the tests run slower. But it's super useful when attaching to a debugger.