Conversation
The reason I chose to submit this is because it was initially unclear from the docs that the transition group needed to already be mounted in order for it to work properly.
There was a problem hiding this comment.
I'll let @chenglou handle comments about content, but just a nit that this link will be broken in the website. It should be /react/docs/animation.html#getting-started or even more simply #getting-started since it's on the same page
There was a problem hiding this comment.
Gotcha. I was thinking that but wasn't sure.
|
Just some nits, otherwise it's good! Also, I didn't even know that. |
|
I'm not sure if it is a bug or not. I just thought this was the way it was meant to work. Did you make the changes that you commented about above, or are you waiting for me to do this? Sorry, this is my first PR for an open source project :) |
|
I guess you made this change through Github's edit button? I think you still can't amend the same PR through Github. You'd have to clone the repo locally, set up the branches, make the changes and yada yada (you can try that). Let's just finish correcting this if no one else has comment (@spicyj), and then you can close this PR and submit a new one. |
|
Ok, @chenglou, I think I corrected them. Regarding |
|
That'll be good for now. Thanks! |
3 participants
First PR and have completed the CLA request
The reason I chose to submit this is because it was initially unclear from the docs that the transition group needed to already be mounted in order for it to work properly.