Merged
Conversation
Just a little less boilerplate. This also removes a bit of trailing whitespace because it shouldn't have been there.
Also, referenced rake release task
zpao
added a commit
to zpao/react
that referenced
this pull request
Aug 13, 2014
Member
Author
|
You can see the result of this in zpao@118e64c (which is applied on a commit where I revert some of the unintentional changes I made to markdown parsing in the last commit to gh-pages, this then makes the same change) |
Collaborator
|
lgtm – thanks in particular for doing the acknowledgements script. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This started as a Jekyll update, then snowballed a bit. Most of the actual content changes here are in bourbon, which is noisy but ultimately not important. The rest of the changes don't result in much - a small change to how code blocks are formatted (just the wrapper really) and less boilerplate. SASS compilation is now handled in Jekyll so we don't have to remember to run a different command there to update.
Since this is a change though, people building docs (@vjeux, @spicyj, @chenglou) will need to make sure they update their installed gems (
bundle install). We should only be running ruby stuff viabundle exec ____to make sure we get the version detection built in. I think I made the mistake recently of updating gems but not generating the site via bundle, which added some noise.