Use double quote for transformed displayName#1708
Merged
zpao merged 1 commit intofacebook:masterfrom Nov 4, 2014
Merged
Conversation
|
@chenglou There is also an issue with the quoteAttrName in the |
Contributor
Author
|
Cool! I'll leave this as a backup then. Will close once yours get merged. |
Member
|
We may move to recast before we ship another release but whatever. Want to rebase and do the |
JSX currently transforms everything to double quote except these two. This way, it's at least consistent and will satisfy half of the people who do put a strict quotation linting on their project. Test: `jest`, check the double quoted transformed `data-bla="something"`.
Contributor
Author
|
Done. |
zpao
added a commit
that referenced
this pull request
Nov 4, 2014
Use double quote for transformed `displayName`
zpao
added a commit
to zpao/react
that referenced
this pull request
Dec 18, 2014
Use double quote for transformed `displayName`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSX currently transforms everything to double quote except these two. This way, it's at least consistent and will satisfy half of the people who do put a strict quotation linting on their project.
Test:
jest, check the double quoted transformeddata-bla="something".