[react-interactions] Add allowModifiers flag to FocusList + FocusTable#16971
Merged
trueadm merged 2 commits intofacebook:masterfrom Oct 1, 2019
Merged
[react-interactions] Add allowModifiers flag to FocusList + FocusTable#16971trueadm merged 2 commits intofacebook:masterfrom
trueadm merged 2 commits intofacebook:masterfrom
Conversation
Details of bundled changes.Comparing: 6c73a1e...94266e9 react-interactions
|
trueadm
force-pushed
the
focus-modifiers
branch
from
de11108 to
33caccb
Compare
Move emulateBrowserTab Move emulateBrowserTab
trueadm
force-pushed
the
focus-modifiers
branch
from
33caccb to
7def627
Compare
bvaughn
reviewed
Oct 1, 2019
| } | ||
| const key = event.key; | ||
|
|
||
| if (key === 'Tab') { |
Contributor
There was a problem hiding this comment.
Given that "shift" is a modifier, and it impacts "Tab" (reverses the direction) it seems odd that we check for key === 'Tab' before bailing out if modifiers aren't allowed. Is this a bug?
Contributor
Author
There was a problem hiding this comment.
The modifiers logic is only for the keyboard arrow keys, not for Tab.
Contributor
There was a problem hiding this comment.
I see. That wasn't super clear to me just looking at the code and going off of the name of the prop. Maybe some inline comment clarifying the intent could be helpful?
bvaughn
approved these changes
Oct 1, 2019
| } | ||
| const key = event.key; | ||
|
|
||
| if (key === 'Tab') { |
Contributor
There was a problem hiding this comment.
I see. That wasn't super clear to me just looking at the code and going off of the name of the prop. Maybe some inline comment clarifying the intent could be helpful?
necolas
reviewed
Oct 1, 2019
| return {}; | ||
| } | ||
|
|
||
| function hasModifierKey(event: KeyboardEvent): boolean { |
Contributor
There was a problem hiding this comment.
This function is already in the 'shared' module
Contributor
Author
There was a problem hiding this comment.
I originally used that thinking the exact same thing, but it's actually slightly different as it expects a different event object (that it reads nativeEvent from). I'm not too bothered about duplication here, we can tidy up once we're happy with the moving parts. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
allowModifiersflag to theFocusListandFocusTablecomponents. This PR also changes the default behaviour for using arrow keys with modifier keys (they're now no-ops). I also moved some of the test code into a different module relating toemulateBrowserTabas per a follow up to @necolas's feedback.