followup to #15763, fix failing test in ReactDOMTracing-test#15972
Merged
threepointone merged 2 commits intofacebook:masterfrom Jun 24, 2019
Merged
followup to #15763, fix failing test in ReactDOMTracing-test#15972threepointone merged 2 commits intofacebook:masterfrom
threepointone merged 2 commits intofacebook:masterfrom
Conversation
It was me. I broke the build.
trueadm
approved these changes
Jun 24, 2019
rickhanlonii
pushed a commit
to rickhanlonii/react
that referenced
this pull request
Jun 25, 2019
…acebook#15972) * followup to facebook#15763, failing tests in ReactDOMTracing-test It was me. I broke the build. * [ignore] add a newline to trigger a build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was me. I broke the build.
I merged 15763 without testing a rebased version locally, which had a failing test. This PR fixes the test (by wrapping a section of the test with
act()).