Add Press event prop types and fix a check in Safari#15288
Merged
trueadm merged 6 commits intofacebook:masterfrom Apr 2, 2019
Merged
Add Press event prop types and fix a check in Safari#15288trueadm merged 6 commits intofacebook:masterfrom
trueadm merged 6 commits intofacebook:masterfrom
Conversation
Details of bundled changes.Comparing: 5ef0d1d...77f2284 react-events
Generated by 🚫 dangerJS |
event.keyCode is a deprecated API
necolas
commented
Apr 1, 2019
packages/react-events/src/Press.js
Outdated
| type PressProps = { | ||
| disabled: boolean, | ||
| delayLongPress: number, | ||
| delayPress: number, |
Contributor
Author
There was a problem hiding this comment.
Remove this prop for now. There's no equivalent that we're currently using (only delay for start/end). And if onPress is not cancelled it is always a "completion" event that occurs immediately after onPressEnd.
necolas
commented
Apr 1, 2019
packages/react-events/src/Press.js
Outdated
| delayPress: number, | ||
| delayPressEnd: number, | ||
| delayPressStart: number, | ||
| hitSlop: Object, |
trueadm
approved these changes
Apr 2, 2019
Contributor
trueadm
left a comment
trueadm
left a comment
There was a problem hiding this comment.
Nice clean up + additional types!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #15257