Minor code structure adjustments to the bundles.js file#15079
Minor code structure adjustments to the bundles.js file#15079cpojer merged 5 commits intofacebook:masterfrom
Conversation
| @@ -434,19 +434,16 @@ const bundles = [ | |||
|
|
|||
| /******* ESLint Plugin for Hooks (proposal) *******/ | |||
| { | |||
There was a problem hiding this comment.
any reason for this change? looks like it was intended to fit under the
/******* ESLint Plugin for Hooks (proposal) *******/ title
There was a problem hiding this comment.
Not from me.
I executed yarn prettier as peer pull request guidance and prettier decided to do that.
|
looks great. does this fix any issue opened? can get it merged faster if so |
I don't think so. It was something I stumbled on as I looked around in the source code. |
Ok it'll be up to maintainers obviously if this will get merged then. I suppose the tests ran ok as well when you ran them? |
|
Yes the test ran ok |
Purpose:
Consistent code in build.js and bundles.js.
build.js destructured bundleTypes, I think bundles.js should too.
yarn prettier on the bundles.js moved stuff around.
Added deepfreeze for bundleTypes and moduleTypes
Before submitting a pull request, please make sure the following is done:
master.yarnin the repository root.yarn test). Tip:yarn test --watch TestNameis helpful in development.yarn test-prodto test in the production environment. It supports the same options asyarn test.yarn debug-test --watch TestName, openchrome://inspect, and press "Inspect".yarn prettier).yarn lint). Tip:yarn lincto only check changed files.yarn flow).Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html