refactor: remove type judgment when defining warning props#13553
Merged
gaearon merged 1 commit intofacebook:masterfrom Sep 4, 2018
Merged
refactor: remove type judgment when defining warning props#13553gaearon merged 1 commit intofacebook:masterfrom
gaearon merged 1 commit intofacebook:masterfrom
Conversation
gebilaoxiong
changed the title
Details of bundled changes.Comparing: 25d48a7...ebf2977 schedule
Generated by 🚫 dangerJS |
Collaborator
|
I don't understand what this code was for, and #5744 doesn't seem to contain hints about it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The judgment in this code seems to be invalid：
https://github.com/facebook/react/blob/master/packages/react/src/ReactElement.js#L233-L234
Because props.$$typeof is always undefined.
I can't see the effect of this judgment from the unit test.
If he is necessary. Please tell me the special use case.
I will add a test case here.